Skip to content

Conversation

@jjw24
Copy link
Member

@jjw24 jjw24 commented Dec 22, 2022

  • Fix directory path search when triggered from quick access
  • Fix autocomplete text when both path and search action keywords are disabled
  • Added unit tests

Note: if both path and search action keywords are disabled, selecting the result will open the folder instead of navigating to the path.

Tested:

  • Select folder result listed via Quick Access will navigate to the path with search action keyword when both search and path search action keywords are enabled or only search action keyword is enabled
  • When search action keyword is disabled and path search is enabled, selecting result will navigate to the path with path search action keyword
  • When both path and search action keywords are disabled, selecting result will open the folder instead
  • When both path and search action keywords are disabled, autocomplete will autocomplete with the title of the folder
  • Using content search will navigate to folder/file paths correctly via autocomplete or selecting folder result

@jjw24 jjw24 added the bug Something isn't working label Dec 22, 2022
@jjw24 jjw24 added this to the 1.11.0 milestone Dec 22, 2022
@jjw24 jjw24 self-assigned this Dec 22, 2022
@jjw24 jjw24 marked this pull request as draft December 22, 2022 12:22
@jjw24 jjw24 marked this pull request as ready for review December 24, 2022 18:02
@jjw24 jjw24 enabled auto-merge December 24, 2022 18:02
@jjw24 jjw24 merged commit 6607acb into dev Dec 25, 2022
@jjw24 jjw24 deleted the fix_quickaccess_autocomplete branch December 25, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants