Skip to content

Configurable preview panel toggle hotkey and use lazy load preview image #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Dec 29, 2022
Merged

Configurable preview panel toggle hotkey and use lazy load preview image #1709

merged 27 commits into from
Dec 29, 2022

Conversation

@VictoriousRaptor
Copy link
Contributor

@VictoriousRaptor VictoriousRaptor commented Dec 22, 2022 •
edited
Loading

Changes:

  • Load preview image when opening preview panel.
  • Add preview hotkey property in settings. (no UI to modify it, can't figure out a good way to edit it yet)
  • Add an option to modifty the hotkey
    图片
  • Add hotkey text in tooltip
    图片
  • Add separate preview delegate in Result class.
  • Add TryGetValue for ImageLoader.

Tests:

  • Preview can be toggled.
  • Preview image changes when changing selected item.
  • Preview hotkey can be modified and works properly.
  • Tootip reflects changes in hotkey.

@VictoriousRaptor VictoriousRaptor added the enhancement New feature or request label Dec 22, 2022
@VictoriousRaptor VictoriousRaptor self-assigned this Dec 22, 2022
@VictoriousRaptor VictoriousRaptor marked this pull request as ready for review December 23, 2022 02:50
@onesounds
Copy link
Contributor

I checked that the pr is working well.
Let's do UI in a separate PR.

onesounds
onesounds previously approved these changes Dec 23, 2022
View reviewed changes
@VictoriousRaptor VictoriousRaptor added this to the 1.11.0 milestone Dec 23, 2022
taooceros
taooceros reviewed Dec 23, 2022
View reviewed changes
@jjw24
Copy link
Member

jjw24 commented Dec 24, 2022

@VictoriousRaptor please resolve conflict.

jjw24
jjw24 reviewed Dec 26, 2022
View reviewed changes
jjw24
jjw24 reviewed Dec 26, 2022
View reviewed changes
jjw24
jjw24 reviewed Dec 27, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this when typing quickly, but most of the time the flickering is not there:

image

@VictoriousRaptor
Copy link
Contributor Author

Getting this when typing quickly, but most of the time the flickering is not there:

image

I can't reproduce when debugger is off. Seems like it's debug time only? Could you reproduce it without debugging?

@jjw24
Copy link
Member

jjw24 commented Dec 29, 2022

Getting this when typing quickly, but most of the time the flickering is not there:
image

I can't reproduce when debugger is off. Seems like it's debug time only? Could you reproduce it without debugging?

Ok, I will test it with release build.

@jjw24
Copy link
Member

jjw24 commented Dec 29, 2022

OK, can't repro in release build.

jjw24
jjw24 reviewed Dec 29, 2022
View reviewed changes
README.md Outdated
| <kbd>Ctrl</kbd> +<kbd>O</kbd> , <kbd>Shift</kbd> +<kbd>Enter</kbd> | Open Context Menu |
| <kbd>Tab</kbd> | Autocomplete |
| <kbd>F1</kbd> | Toggle Preveiw Panel |
| <kbd>F1</kbd> | Toggle Preveiw Panel (default and configurable)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| <kbd>F1</kbd> | Toggle Preveiw Panel (default and configurable)|
| <kbd>F1</kbd> | Toggle Preveiw Panel |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to #1723 so users won't get confused as this has not been release yet.

jjw24
jjw24 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jjw24 jjw24 changed the title Lazy load preview image Configurable panel preview toggle hotkey and use lazy load preview image Dec 29, 2022
@jjw24 jjw24 changed the title Configurable panel preview toggle hotkey and use lazy load preview image Configurable preview panel toggle hotkey and use lazy load preview image Dec 29, 2022
@VictoriousRaptor VictoriousRaptor merged commit f42f87c into Flow-Launcher:dev Dec 29, 2022
@jjw24 jjw24 mentioned this pull request Dec 30, 2022
Merged
@VictoriousRaptor VictoriousRaptor mentioned this pull request Dec 30, 2022
Closed
@VictoriousRaptor VictoriousRaptor deleted the LazyLoadPreview branch December 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taooceros taooceros taooceros left review comments

@jjw24 jjw24 jjw24 approved these changes

@onesounds onesounds onesounds left review comments

Assignees

@VictoriousRaptor VictoriousRaptor

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@VictoriousRaptor @onesounds @jjw24 @taooceros