Fix: Add admin permissions when non-admin doesn't work #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngtr6788
force-pushed
the
windows-settings-elevation
branch
from
331b9a7 to
6cc5fe8
Compare
|
Thanks! |
taooceros
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1396.
What I am trying to do in this PR is that we run the process as normal, and if the process throws an "elevated permission error" (belonging to Win32Exception), it tries again with elevated permissions, and if that doesn't work, we throw. My (hopeful) reasoning is that we don't want to elevate permissions right from the get-go and only elevate when we need to.
Again, I'm pretty new to the codebase and C# in general, so feedback is greatly appreciated!