Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Jun 8, 2023

Context:
Following on from #2143, further refactor and making copy consistent throughout flow.

Changes:

  1. Updated CopyToClipboard API method
    a. Added directCopy parameter for directly copying files/folder
    b. Added showDefaultNotification parameter to allow caller to suppress the method's notification and provide its own
    c. Move actual copy code away from ViewModel, they do not need to live there
  2. Nothing is using TryToCopyToClipBoard method, removed.
  3. This error occurs occasionally when using Clipboard.SetText call rather than SetDataObject.
    image
  4. Added CopyText for Shell plugin

Tested:

  1. Copy selected query does not show notification
  2. Copy Bookmark plugin result copies the url
  3. Copy Shell plugin result copies the command
  4. Explorer Context Menu result 'Copy Path' copies the path not folder/file
  5. Copy Explorer plugin result copies the folder
  6. Copy Explorer plugin result copies the file
  7. Checked no plugin is actually using CopyToClipboard API method aside from the default ones

@jjw24 jjw24 marked this pull request as draft June 8, 2023 13:18
@github-actions

This comment has been minimized.

@jjw24 jjw24 self-assigned this Jun 8, 2023
@jjw24 jjw24 added bug Something isn't working Code Refactor labels Jun 8, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jun 11, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (53)
addfilefoldersuccess
browserbookmark
caculator
clocksb
CMDs
contextmenu
copyfilefolder
copyfolder
copylink
copypath
copyurl
cretain
deletefile
deletefilefolder
deletefilefoldersuccess
deletefolder
dlgtitle
eig
eigval
eigvec
epicgames
eror
excludedfromindexsearch
excludefromindexsearch
excmd
gamemode
iconsb
LINQ
LWin
mainwindow
matchs
Mvvm
opencontainingfolder
openindexingoptions
openwitheditor
openwithshell
positionreset
Ptr
quickaccess
refeshes
Reloadable
removefilefoldersuccess
requerying
Restar
RPressed
RStroked
runasdifferentuser
rungameid
Seperator
spefic
titletooltip
viewupdate
windowsb
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the refactor_copy branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/5235274565/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 marked this pull request as ready for review June 11, 2023 12:13
@jjw24 jjw24 enabled auto-merge June 11, 2023 12:13
@jjw24 jjw24 added this to the 1.15.1 milestone Jun 11, 2023
@jjw24 jjw24 merged commit 144fdad into dev Jun 11, 2023
@jjw24 jjw24 deleted the refactor_copy branch June 11, 2023 13:21
@jjw24 jjw24 modified the milestones: 1.15.1, 1.16.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Code Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants