Skip to content

Conversation

JohnTheGr8
Copy link
Member

Started wanting to update the Readme to mention Ctrl+R after #2174 (comment) ... ended up doing a documentation pass in the Flow.Launcher.Plugin package.

I also updated the plugin readme and made it show up on the nuget page.

@JohnTheGr8 JohnTheGr8 added the Documentation Update required to documentation label Jun 18, 2023
@JohnTheGr8 JohnTheGr8 added this to the 1.15.1 milestone Jun 18, 2023
@JohnTheGr8 JohnTheGr8 requested review from jjw24 and taooceros June 18, 2023 20:43
@JohnTheGr8 JohnTheGr8 self-assigned this Jun 18, 2023
@jjw24 jjw24 modified the milestones: 1.15.1, 1.16.0 Jun 22, 2023
Copy link
Member

@taooceros taooceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also want to update the plugin development readme? Though I think it's ok to leave it in future.

Comment on lines -59 to 61
<ItemGroup>
<None Include="README.md" />
<None Include="Readme.md" Pack="true" PackagePath="\"/>
<None Include="FodyWeavers.xml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these change means? Does Readme.md work in Github?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's added so that the Readme file is rendered in nuget.org page of the package, see for example our dotnet-new template

@JohnTheGr8
Copy link
Member Author

Maybe we also want to update the plugin development readme? Though I think it's ok to leave it in future.

let's leave that for later

@JohnTheGr8 JohnTheGr8 enabled auto-merge June 25, 2023 11:19
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohnTheGr8 JohnTheGr8 merged commit a48f060 into Flow-Launcher:dev Jun 26, 2023
@jjw24 jjw24 added the bug Something isn't working label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Documentation Update required to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants