-
-
Notifications
You must be signed in to change notification settings - Fork 446
Update Plugin documentation #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we also want to update the plugin development readme? Though I think it's ok to leave it in future.
<ItemGroup> | ||
<None Include="README.md" /> | ||
<None Include="Readme.md" Pack="true" PackagePath="\"/> | ||
<None Include="FodyWeavers.xml" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do these change means? Does Readme.md work in Github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's added so that the Readme file is rendered in nuget.org page of the package, see for example our dotnet-new template
let's leave that for later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Started wanting to update the Readme to mention
Ctrl+R
after #2174 (comment) ... ended up doing a documentation pass in theFlow.Launcher.Plugin
package.I also updated the plugin readme and made it show up on the nuget page.