Use api function to hide window

[Jack251970]

Use HideMainWindow() instead of Application.Current.MainWindow.Hide(); for code consistence

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update how the application window is hidden during specific plugin operations. Both in the Plugins Manager and the Sys Main classes, the direct call to hide the main window is replaced with an API call (Context.API.HideMainWindow()). This adjustment is applied in methods handling plugin installation, uninstallation, and execution of system commands, without altering the existing control flow or public interfaces.

Changes

File(s)	Change Summary
Plugins/.../PluginsManager.cs	Updated InstallFromWeb, InstallFromLocalPath, and RequestUninstall methods to replace Application.Current.MainWindow.Hide() with Context.API.HideMainWindow().
Plugins/.../Sys/Main.cs	Modified commands for "Reload Plugin Data" and "Check For Update" to replace Application.Current.MainWindow.Hide() with Context.API.HideMainWindow().

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PluginManager
    participant API

    User->>PluginManager: Initiate Install/Uninstall
    PluginManager->>API: HideMainWindow()
    API-->>PluginManager: Confirm window hidden
    PluginManager-->>User: Continue with plugin process

Loading

sequenceDiagram
    participant User
    participant SysMain
    participant API

    User->>SysMain: Execute "Reload Plugin Data"/"Check For Update"
    SysMain->>API: HideMainWindow()
    API-->>SysMain: Main window hidden
    SysMain-->>User: Proceed with command execution

Loading

Possibly related PRs

• Improve uninstaller check function #3197: Implements similar modifications to encapsulate main window hiding using the API.
• perf: hide main window from alt tab program switcher #3241: Addresses window hiding changes in a different context using the new API method.
• Fix setting window freeze issue & Improve singleton window opener #3204: Involves updates to how the main application window is hidden, aligning with the method used in this PR.

Suggested reviewers

• jjw24

Poem

I'm a little rabbit, gentle and spry,
Hoping through code, with a twinkle in my eye.
Changed a call here and swapped it out there,
A simple tweak with so much flair.
Code hops along, light and free – oh my!
🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9917de9 and 9284c55.

📒 Files selected for processing (2)

• Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs (4 hunks)
• Plugins/Flow.Launcher.Plugin.Sys/Main.cs (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs (2)

335-337: LGTM! Good use of the API method.

The change improves code consistency by using the API method instead of directly manipulating the window. The comment explains well why hiding is necessary before reloading.

---

355-355: LGTM! Consistent with the API usage pattern.

Using context.API.HideMainWindow() aligns with the codebase's preferred approach for window management.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ ignored-expect-variant	1
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, jjw24 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

Activity based on git-commit:

	Jack251970
FEB	35 additions & 28 deletions
JAN	291 additions & 247 deletions
DEC
NOV	28 additions & 28 deletions
OCT
SEP

Knowledge based on git-blame:
Jack251970: 17%
jjw24: 15%

Plugins/Flow.Launcher.Plugin.Sys/Main.cs

Activity based on git-commit:

	Jack251970
FEB	92 additions & 48 deletions
JAN
DEC	12 additions & 38 deletions
NOV	12 additions & 14 deletions
OCT
SEP

Knowledge based on git-blame:
Jack251970: 18%
jjw24: 14%

To learn more about /:\ gitStream - Visit our Docs