Adjust Numberbox Design & Revert PositionResetToolTip string

[onesounds]

What's the PR

Before

After

• Fixed a visual issue where the NumberBox appeared editable when disabled
  • especially noticeable in the dark color scheme
  • When the setting was turned off, I could attempt to edit without understanding why it wasn’t working
• Added immediate tooltip on mouse hover.
• Tooltip clarifies that "Search Delay must be enabled in General to edit."
• Restored a string that Jack had previously removed. https://github.com/Flow-Launcher/Flow.Launcher/pull/3396/files#r2038439277

[coderabbitai]

📝 Walkthrough

Walkthrough

This change adds two new tooltip strings to the localization resource file (en.xaml) and updates the UI controls to reference these new strings. The InstalledPluginDisplay.xaml file has its tooltip reference updated for the NumberBox control and further tooltip display properties added. Additionally, the CustomControlTemplate.xaml file receives styling adjustments for TextBox triggers based on different interaction states.

Changes

File	Change Summary
Flow.Launcher/Languages/en.xaml	Added new string entries: PositionResetToolTip ("Reset search window position") and searchDelayNumberBoxToolTip ("Enter the wait time (in ms) until input is considered complete. This can only be edited if Search Delay is enabled.")
Flow.Launcher/Resources/Controls/InstalledPluginDisplay.xaml	Updated the NumberBox control's tooltip reference from {DynamicResource searchDelayToolTip} to {DynamicResource searchDelayNumberBoxToolTip}; added ToolTipService.InitialShowDelay="0" and ToolTipService.ShowOnDisabled="True"
Flow.Launcher/Resources/CustomControlTemplate.xaml	Modified TextBox triggers: for disabled state, updated background, border thickness, and foreground; for mouse over state, updated border brush and background; for selection active state, updated border brush, border thickness, and foreground

Possibly related PRs

• Support Preview Panel for History Results #3370: The changes in the main PR, which involve adding new tooltip strings for UI elements, are related to the modifications in the retrieved PR that update the tooltip property for a control, as both pertain to enhancing user interface elements through localization and tooltip functionality.
• Organizing the settings page #3400: The changes in the main PR, which involve adding new tooltip strings in the en.xaml file, are related to the modifications in the retrieved PR that update the tooltip reference in the InstalledPluginDisplay.xaml file, as both pertain to tooltip functionality within the Flow Launcher application.
• Improve Report Window Design #3264: The changes in the main PR, which add new string entries for tooltips in the en.xaml file, are related to the changes in the retrieved PR that also modifies the en.xaml file by adding new string resources for the report window, indicating both PRs are enhancing localization resources within the same file.

Suggested labels

enhancement

Suggested reviewers

• Jack251970

Poem

I'm a hopping rabbit with a code delight,
New tooltips and styles make the UI bright.
I nibble on strings with a joyful cheer,
As each change sharpens what's clear.
With a hop and a skip in every byte,
This PR fills my heart with carrot light!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e54416 and c5f2868.

📒 Files selected for processing (1)

• Flow.Launcher/Converters/QuerySuggestionBoxConverter.cs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: gitStream.cm

🔇 Additional comments (2)

Flow.Launcher/Converters/QuerySuggestionBoxConverter.cs (2)

3-3: Added required namespace for FlowDirection.

The addition of the System.Windows namespace is necessary to support the FlowDirection parameter used in the FormattedText constructor.

---

47-56: Improved DPI awareness for text rendering.

These changes properly implement DPI-aware text rendering by:

1. Retrieving the DPI information from the visual tree
2. Using the PixelsPerDip value in the FormattedText constructor
3. Restructuring the code for better readability

This enhancement ensures text displays correctly across different screen resolutions and scaling settings, which aligns with the PR objective of improving UI visual consistency.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[onesounds]

Removed it due to a warning suggesting to include DPI information.

[Copilot]

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)

• Flow.Launcher/Languages/en.xaml: Language not supported
• Flow.Launcher/Resources/Controls/InstalledPluginDisplay.xaml: Language not supported
• Flow.Launcher/Resources/CustomControlTemplate.xaml: Language not supported