Improve FL Exiting & Exception Handler

[Jack251970]

Use try-catch to call plugin Save & Dispose method so that Application can exit normally even plugins have exceptions

Tested. When plugin throw exception during saving & disposing, the application can exit normally.

Fix storage DirectoryPath issue

Make DirectoryPath is not null. Follow on with #3452.

Support TaskScheduler.UnobservedTaskException handler

Fix #3453.

[gitstream-cm]

🚨 Warning: Approaching Monthly Automation Limit

Monthly PRs automated: 234/250

Your organization has used over 90% of its monthly quota for gitStream automations. Once the quota is reached, new pull requests for this month will not trigger gitStream automations and will be marked as “Skipped”.

To avoid interruptions, consider optimizing your automation usage or upgrading your plan by contacting LinearB.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Flow.Launcher/Core/Resource/Internationalization.cs:260

• Using 'return' in the foreach loop may exit the method prematurely instead of skipping a single plugin. Consider replacing 'return' with 'continue' to process all plugins.

                if (p.Plugin is not IPluginI18n pluginI18N) return;

[gitstream-cm]

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Core/Plugin/PluginManager.cs

Activity based on git-commit:

	Jack251970
APR	34 additions & 42 deletions
MAR	42 additions & 37 deletions
FEB	276 additions & 198 deletions
JAN	5 additions & 5 deletions
DEC
NOV	1 additions & 1 deletions

Knowledge based on git-blame:
Jack251970: 23%

Flow.Launcher.Core/Resource/Internationalization.cs

Activity based on git-commit:

	Jack251970
APR
MAR	67 additions & 40 deletions
FEB	5 additions & 4 deletions
JAN	81 additions & 42 deletions
DEC
NOV	3 additions & 3 deletions

Knowledge based on git-blame:
Jack251970: 33%

Flow.Launcher.Infrastructure/Storage/BinaryStorage.cs

Activity based on git-commit:

	Jack251970
APR	84 additions & 32 deletions
MAR
FEB	9 additions & 16 deletions
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 57%

Flow.Launcher.Infrastructure/Storage/FlowLauncherJsonStorage.cs

Activity based on git-commit:

	Jack251970
APR	38 additions & 3 deletions
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:
Jack251970: 71%

Flow.Launcher.Plugin/SharedCommands/FilesFolders.cs

Activity based on git-commit:

	Jack251970
APR	46 additions & 0 deletions
MAR
FEB
JAN
DEC	11 additions & 6 deletions
NOV	17 additions & 12 deletions

Knowledge based on git-blame:
Jack251970: 18%

Flow.Launcher/App.xaml.cs

Activity based on git-commit:

	Jack251970
APR	18 additions & 6 deletions
MAR	168 additions & 94 deletions
FEB	79 additions & 40 deletions
JAN	86 additions & 66 deletions
DEC
NOV

Knowledge based on git-blame:
Jack251970: 63%

Flow.Launcher/Helper/ErrorReporting.cs

Activity based on git-commit:

	Jack251970
APR
MAR
FEB
JAN
DEC
NOV

Knowledge based on git-blame:

Flow.Launcher/MainWindow.xaml.cs

Activity based on git-commit:

	Jack251970
APR	16 additions & 5 deletions
MAR	1141 additions & 1076 deletions
FEB	1 additions & 1 deletions
JAN
DEC	5 additions & 10 deletions
NOV

Knowledge based on git-blame:
Jack251970: 63%

Flow.Launcher/PublicAPIInstance.cs

Activity based on git-commit:

	Jack251970
APR	153 additions & 51 deletions
MAR	21 additions & 19 deletions
FEB	28 additions & 11 deletions
JAN	45 additions & 47 deletions
DEC	25 additions & 32 deletions
NOV	16 additions & 0 deletions

Knowledge based on git-blame:
Jack251970: 44%

To learn more about /:\ gitStream - Visit our Docs

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces a series of modifications across several components. In the plugin management code, error handling is enhanced with added try-catch blocks, and some fields are marked as readonly to prevent reassignment. Several methods have been refactored to use modern C# syntax, including shorthand initializers and the range operator for string manipulation. The PR also refactors dependency usage in the Public API class and improves the shutdown process by updating control flow in the main window. Additionally, it adds new logic to handle unobserved task exceptions via the application’s task scheduler.

Changes

Files	Change Summary
Flow.Launcher.Core/Plugin/PluginManager.cs	Marked _modifiedPlugins as readonly; added try-catch blocks around save and disposal methods with logging modifications; reformatted a return statement for clarity.
Flow.Launcher.Core/Resource/Internationalization.cs	Updated list initializations; changed several methods (e.g., GetTranslation, GetLanguageByLanguageCode, LanguageFile) to static and modified visibility where needed; refactored null checks using pattern matching.
Flow.Launcher.Infrastructure/Storage/BinaryStorage.cs, Flow.Launcher.Infrastructure/Storage/FlowLauncherJsonStorage.cs	Revised constructor implementations to directly assign and validate DirectoryPath, ensuring consistency in file path construction.
Flow.Launcher.Plugin/SharedCommands/FilesFolders.cs	Replaced usage of Substring with the range operator for string slicing and replaced empty string literals with string.Empty.
Flow.Launcher/App.xaml.cs, Flow.Launcher/Helper/ErrorReporting.cs	Added a new method in App.xaml.cs to register the task scheduler’s unobserved exceptions and introduced a corresponding handler in ErrorReporting.cs to report and mark exceptions as observed.
Flow.Launcher/MainWindow.xaml.cs	Modified the OnClosing method by moving the CanClose assignment to the beginning of the condition and updating the shutdown comments for clarity.
Flow.Launcher/PublicAPIInstance.cs	Removed the Internationalization dependency in favor of direct static calls; introduced an Updater field and updated CheckForNewUpdate to avoid circular dependencies.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant TaskScheduler
    participant ErrorReporting

    App->>TaskScheduler: RegisterTaskSchedulerUnhandledException()
    Note right of App: Registered in RELEASE builds
    TaskScheduler-->>ErrorReporting: OnUnobservedTaskException event
    ErrorReporting->>App: TaskSchedulerUnobservedTaskException invoked

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure graceful application exit ignoring exit-time errors [#3453]	✅

Suggested labels

Code Quality

Suggested reviewers

• onesounds

Poem

Oh, I'm a rabbit with code so bright,
Hopping through changes with delight.
Error traps caught with a savvy bound,
Static methods and paths now sound.
In this burrow of code, I cheer with glee 🐰,
Celebrating improvements, happy as can be!
Hop, hop—onto the next release spree!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5045f19 and 5bafe23.

📒 Files selected for processing (1)

• Flow.Launcher/Helper/ErrorReporting.cs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Flow.Launcher/Helper/ErrorReporting.cs

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm
• GitHub Check: gitStream.cm

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors	Count
❌ forbidden-pattern	24
⚠️ non-alpha-in-dictionary	19

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[Jack251970]

I think it is good to go