Fix size changed width issue #3544

Jack251970 · 2025-05-14T06:25:45Z

Check if width <= 0 before calculate column width.

Please open new issue in https://github.com/Flow-Launcher/Flow.Launcher/issues
1. Upload log file: C:\Users\default.MyPC\AppData\Roaming\FlowLauncher\Logs\1.0.0\2025-05-13.txt
2. Copy below exception message

Flow Launcher version: 1.0.0
OS Version: 22631.5189
IntPtr Length: 8
x64: True

Python Path: C:\Users\default.MyPC\AppData\Roaming\FlowLauncher\Environments\Python\PythonEmbeddable-v3.11.4\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe

Date: 05/13/2025 11:37:45
Exception:
System.ArgumentException: '-4.333333333333333' is not a valid value for property 'Width'.
   at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
   at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
   at Flow.Launcher.Plugin.Program.Views.ProgramSetting.ListView_SizeChanged(Object sender, SizeChangedEventArgs e) in C:\Flow.Launcher\Plugins\Flow.Launcher.Plugin.Program\Views\ProgramSetting.xaml.cs:line 468
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.FrameworkElement.OnRenderSizeChanged(SizeChangedInfo sizeInfo)
   at System.Windows.ContextLayoutManager.fireSizeChangedEvents()
   at System.Windows.ContextLayoutManager.UpdateLayout()
   at System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
   at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
   at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
   at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Jack251970 · 2025-05-14T06:26:43Z

Small fix PR and I think it is good to go.

gitstream-cm · 2025-05-14T06:26:46Z

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970, jjw24 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Program/Views/ProgramSetting.xaml.cs

Activity based on git-commit:

	Jack251970
MAY
APR	16 additions & 12 deletions
MAR
FEB	13 additions & 3 deletions
JAN
DEC

Knowledge based on git-blame:
jjw24: 37%
Jack251970: 7%

Plugins/Flow.Launcher.Plugin.Sys/SysSettings.xaml.cs

Activity based on git-commit:

	Jack251970
MAY
APR
MAR	41 additions & 23 deletions
FEB
JAN
DEC

Knowledge based on git-blame:
Jack251970: 52%
jjw24: 2%

To learn more about /:\ gitStream - Visit our Docs

gitstream-cm · 2025-05-14T06:26:54Z

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

github-actions · 2025-05-14T06:27:06Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	22
⚠️ non-alpha-in-dictionary	13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

coderabbitai · 2025-05-14T06:27:45Z

📝 Walkthrough

Walkthrough

Guard clauses were introduced or repositioned in ListView size change event handlers within two plugin settings files to ensure early exit when the calculated working width is non-positive. This change prevents further execution of column width adjustment logic under invalid width conditions, improving code clarity and robustness.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Program/Views/ProgramSetting.xaml.cs	Added a guard clause in `ListView_SizeChanged` to return early if `workingWidth <= 0`.
Plugins/Flow.Launcher.Plugin.Sys/SysSettings.xaml.cs	Reformatted `workingWidth` calculation and moved the non-positive width check immediately after it.

Suggested reviewers

jjw24
taooceros

Poem

A rabbit nibbled code so neat,
Guarding widths from zero’s defeat.
Early returns now hop in place,
Preventing bugs with gentle grace.
With every hop, the layout's sure—
Robust and clear, the code is pure!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a75553f and 8325963.

📒 Files selected for processing (2)

Plugins/Flow.Launcher.Plugin.Program/Views/ProgramSetting.xaml.cs (1 hunks)
Plugins/Flow.Launcher.Plugin.Sys/SysSettings.xaml.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: gitStream.cm
GitHub Check: gitStream workflow automation
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: gitStream.cm
GitHub Check: build

🔇 Additional comments (2)

Plugins/Flow.Launcher.Plugin.Program/Views/ProgramSetting.xaml.cs (1)

435-437: Good defensive coding practice!

Adding this guard clause is an excellent improvement that prevents potential issues when the calculated width is non-positive. This will avoid unnecessary calculations and potential display anomalies when the ListView doesn't have sufficient width to properly distribute to columns.

Plugins/Flow.Launcher.Plugin.Sys/SysSettings.xaml.cs (1)

24-27: Improved readability and error handling

The reformatting of the working width calculation and addition of the guard clause improves both readability and robustness. Checking for non-positive width values prevents potential layout issues or unexpected behavior when the ListView doesn't have enough space.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jjw24 · 2025-05-14T11:04:48Z

Is there an associated issue with this?

Jack251970 · 2025-05-14T11:06:05Z

Is there an associated issue with this?

From cibere's comments in discord

jjw24 · 2025-05-14T11:21:29Z

Ok no worries.

Fix size changed width issue

8325963

prlabeler bot added the bug Something isn't working label May 14, 2025

github-actions bot assigned Jack251970 May 14, 2025

Jack251970 requested a review from onesounds May 14, 2025 06:26

Jack251970 enabled auto-merge May 14, 2025 06:26

Jack251970 added this to the 1.20.0 milestone May 14, 2025

onesounds approved these changes May 14, 2025

View reviewed changes

Jack251970 merged commit 8522d78 into dev May 14, 2025
16 checks passed

Jack251970 deleted the width-issue branch May 14, 2025 06:38

jjw24 mentioned this pull request Jun 1, 2025

Release 1.20.0 | Plugin 4.5.0 #3269

Merged

Uh oh!

Fix size changed width issue #3544

Fix size changed width issue #3544

Uh oh!

Conversation

Jack251970 commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jack251970 commented May 14, 2025

Uh oh!

gitstream-cm bot commented May 14, 2025

Uh oh!

gitstream-cm bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

coderabbitai bot commented May 14, 2025

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

jjw24 commented May 14, 2025

Uh oh!

Jack251970 commented May 14, 2025

Uh oh!

jjw24 commented May 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jack251970 commented May 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)