Skip to content

Conversation

Jack251970
Copy link
Member

Throw exception from OpenInBrowserWindow & OpenInBrowserTab function in SearchWeb and handle them in OpenUri of PublicAPIInstance.

Resolve #3473.

@Jack251970 Jack251970 requested a review from Copilot June 4, 2025 14:31
@Jack251970 Jack251970 self-assigned this Jun 4, 2025
@Jack251970 Jack251970 added the bug Something isn't working label Jun 4, 2025
@Jack251970 Jack251970 added this to the 1.20.1 milestone Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the web search issue by improving error handling for browser operations.

  • Wraps calls to OpenInBrowserTab and OpenInBrowserWindow in a try-catch in PublicAPIInstance.cs
  • Updates the browser error message text in Languages/en.xaml
  • Refactors SearchWeb.cs with updated C# syntax and using statement ordering

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Flow.Launcher/PublicAPIInstance.cs Wraps browser-opening calls in a try-catch block to handle and log exceptions
Flow.Launcher/Languages/en.xaml Adds a new error message string for browser open failures
Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs Updates syntax (e.g., slicing operator) and using statement ordering for clarity
Comments suppressed due to low confidence (1)

Flow.Launcher/Languages/en.xaml:476

  • [nitpick] Consider revising the error message text for clarity and consistency (e.g., 'An error occurred while opening the URL in the browser. Please check your default web browser settings on the General page.').
<system:String x:Key="browserOpenError">An error occurred while opening the url in browser. Please check your setting in Default Web Browser of general page.</system:String>

@Jack251970 Jack251970 changed the title Websearch issue Fix OpenUri Exception Jun 4, 2025
Copy link

gitstream-cm bot commented Jun 4, 2025

🥷 Code experts: onesounds, jjw24

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs

Activity based on git-commit:

Jack251970 onesounds
JUN
MAY
APR
MAR
FEB 4 additions & 1 deletions
JAN

Knowledge based on git-blame:
Jack251970: 4%

Flow.Launcher/Languages/en.xaml

Activity based on git-commit:

Jack251970 onesounds
JUN 1 additions & 0 deletions
MAY 12 additions & 3 deletions 15 additions & 2 deletions
APR 22 additions & 21 deletions 45 additions & 23 deletions
MAR 67 additions & 42 deletions 8 additions & 3 deletions
FEB 15 additions & 9 deletions
JAN 1 additions & 0 deletions

Knowledge based on git-blame:
onesounds: 43%
Jack251970: 11%

Flow.Launcher/PublicAPIInstance.cs

Activity based on git-commit:

Jack251970 onesounds
JUN 1 additions & 1 deletions
MAY 124 additions & 131 deletions 190 additions & 74 deletions
APR 165 additions & 61 deletions
MAR 21 additions & 19 deletions
FEB 28 additions & 11 deletions
JAN 45 additions & 47 deletions

Knowledge based on git-blame:
Jack251970: 49%
onesounds: 9%

To learn more about /:\ gitStream - Visit our Docs

1 similar comment
Copy link

gitstream-cm bot commented Jun 4, 2025

🥷 Code experts: onesounds, jjw24

Jack251970, onesounds have most 👩‍💻 activity in the files.
Jack251970, onesounds have most 🧠 knowledge in the files.

See details

Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs

Activity based on git-commit:

Jack251970 onesounds
JUN
MAY
APR
MAR
FEB 4 additions & 1 deletions
JAN

Knowledge based on git-blame:
Jack251970: 4%

Flow.Launcher/Languages/en.xaml

Activity based on git-commit:

Jack251970 onesounds
JUN 1 additions & 0 deletions
MAY 12 additions & 3 deletions 15 additions & 2 deletions
APR 22 additions & 21 deletions 45 additions & 23 deletions
MAR 67 additions & 42 deletions 8 additions & 3 deletions
FEB 15 additions & 9 deletions
JAN 1 additions & 0 deletions

Knowledge based on git-blame:
onesounds: 43%
Jack251970: 11%

Flow.Launcher/PublicAPIInstance.cs

Activity based on git-commit:

Jack251970 onesounds
JUN 1 additions & 1 deletions
MAY 124 additions & 131 deletions 190 additions & 74 deletions
APR 165 additions & 61 deletions
MAR 21 additions & 19 deletions
FEB 28 additions & 11 deletions
JAN 45 additions & 47 deletions

Knowledge based on git-blame:
Jack251970: 49%
onesounds: 9%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Jun 4, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

1 similar comment
Copy link

gitstream-cm bot commented Jun 4, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

This comment has been minimized.

Copy link
Contributor

coderabbitai bot commented Jun 4, 2025

📝 Walkthrough

Walkthrough

The changes introduce improved error handling when opening URLs in the browser. A fallback mechanism is added to attempt direct URL opening if the initial browser launch fails, and a user-facing error message is displayed when both attempts fail. Additionally, a new localized error string is added for user notification.

Changes

File(s) Change Summary
Flow.Launcher.Plugin/SharedCommands/SearchWeb.cs Added fallback mechanism in browser opening methods; improved exception handling and code refactoring.
Flow.Launcher/PublicAPIInstance.cs Wrapped browser opening logic in try-catch; added error logging and user notification via message box.
Flow.Launcher/Languages/en.xaml Added new localized string resource for browser open error message.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PublicAPIInstance
    participant SearchWeb
    participant OS

    User->>PublicAPIInstance: OpenUri(uri)
    PublicAPIInstance->>SearchWeb: OpenInBrowserTab/Window(url, ...)
    alt Browser open succeeds
        SearchWeb->>OS: Launch browser with URL
        OS-->>SearchWeb: Success
        SearchWeb-->>PublicAPIInstance: Success
    else Browser open fails
        SearchWeb->>OS: Try direct URL open (fallback)
        alt Fallback succeeds
            OS-->>SearchWeb: Success
            SearchWeb-->>PublicAPIInstance: Success
        else Fallback fails
            OS-->>SearchWeb: Error
            SearchWeb-->>PublicAPIInstance: Exception
            PublicAPIInstance->>User: Show error message (browserOpenError)
        end
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Fix "Application not found" error and add robust fallback/error handling when opening browser (#3473)
Notify user with a clear error message if browser opening fails (#3473)

Poem

A bunny hopped to open a site,
But the browser gave quite a fright!
With fallback and care,
Now errors are rare—
And users get messages clear and bright.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6c75c2 and 25a62c8.

📒 Files selected for processing (1)
  • Flow.Launcher/Languages/en.xaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Flow.Launcher/Languages/en.xaml
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Report (PR)
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jjw24 jjw24 enabled auto-merge June 5, 2025 02:47
Copy link

github-actions bot commented Jun 5, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@jjw24 jjw24 merged commit 86ca41a into dev Jun 5, 2025
13 checks passed
@jjw24 jjw24 deleted the websearch_issue branch June 5, 2025 03:01
@Jack251970 Jack251970 linked an issue Jun 5, 2025 that may be closed by this pull request
2 tasks
@jjw24 jjw24 changed the title Fix OpenUri Exception Fix WebSearch plugin crash from certain Uri paths Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Crash when invoking Web Search plugin BUG: Application not found when opening process

2 participants