Skip to content

Conversation

taooceros
Copy link
Member

Add automatic check for dependency update

@jjw24
Copy link
Member

jjw24 commented Jun 23, 2021

Upping the versions will require testing, would it not be better to test while you are choosing to upgrade the version?

This will create a lot of noise in the pr section

@taooceros
Copy link
Member Author

taooceros commented Jun 23, 2021

Upping the versions will require testing, would it not be better to test while you are choosing to upgrade the version?

This will create a lot of noise in the pr section

We can make that check weekly/monthly, which means it will only create a version update pr once a week/month. In most situation, we don't update version because we are lazy to update hhh🤣 (or not notice there's an update).

@jjw24
Copy link
Member

jjw24 commented Jun 23, 2021

Isn't this going to run through and create a pr for every version upgrade? This is going to create a fair bit prs.

Again you have to test to do the upgrade, which I would prefer effort put into enhancements instead and upgrade the required packages if needed

@taooceros
Copy link
Member Author

Isn't this going to run through and create a pr for every version upgrade? This is going to create a fair bit prs.

I don't think so. It shall create one pr once a week for all update if it has detected an update.

Again you have to test to do the upgrade, which I would prefer effort put into enhancements instead and upgrade the required packages if needed

Unless there's a breaking change (like squirrel), I don't think updating the a dependency will require a lot of testing.

@jjw24
Copy link
Member

jjw24 commented Jun 23, 2021

We have a lot of old packages, it's going to upgrade a lot of them.

Can you check how many updates it will create for please

@taooceros
Copy link
Member Author

I will take a try in my fork first.

@taooceros
Copy link
Member Author

taooceros commented Aug 7, 2021

image
It will behave like this. Each update with an pull request, and it will list the release note and commit difference for each update.
taooceros#10

@jjw24
Copy link
Member

jjw24 commented Aug 8, 2021

only 5 packages need updating?

@taooceros
Copy link
Member Author

only 5 packages need updating?

No, it is because we can limit the count of pr created one time (which is 5)

@jjw24
Copy link
Member

jjw24 commented Aug 8, 2021

Would it be better before applying the bot to make an individual branch, upgrade all the non-breaking upgrades on this branch, test them out and merge into dev first?

@taooceros
Copy link
Member Author

Would it be better before applying the bot to make an individual branch, upgrade all the non-breaking upgrades on this branch, test them out and merge into dev first?

Sounds reasonable

@jjw24 jjw24 added this to the Future milestone Sep 27, 2021
@jjw24 jjw24 added the enhancement New feature or request label Sep 27, 2021
@taooceros
Copy link
Member Author

@jjw24 shall we merge the dependabot?

@jjw24
Copy link
Member

jjw24 commented Sep 5, 2022

We have a lot of prs in the pipeline atm, will this change add a lot more? If so can we bump all NuGet packages on a seperate branch, test everything ok and merge in before merging this one so we start with a good baseline.

@Garulf
Copy link
Member

Garulf commented Sep 12, 2022

@taooceros
Copy link
Member Author

You can limit the maximum PR's dependabot is able to create with: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit

the default is 5, which I think is quite reasonable

@Garulf
Copy link
Member

Garulf commented Sep 22, 2022

Seems reasonable to me. Our tests will still run on each PR so in theory we get updated packages for free.

@jjw24
Copy link
Member

jjw24 commented Sep 22, 2022

Ok let's merge this after 1.9.5

@taooceros
Copy link
Member Author

Shall we merge this? @jjw24

@taooceros taooceros enabled auto-merge (squash) October 11, 2022 21:04
@taooceros taooceros merged commit 31daacb into dev Oct 11, 2022
@taooceros taooceros deleted the add-denpendency-bot branch October 11, 2022 21:12
@jjw24 jjw24 removed this from the Future milestone Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants