Skip to content

Refactor Bookmark plugin #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2021
Merged

Refactor Bookmark plugin #695

merged 6 commits into from
Oct 11, 2021

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Sep 21, 2021 •
edited
Loading

will close #694
Refactor Bookmark plugin

  1. Load Chromium bookmark with Json Parse instead of Regex match.
  2. Use inheritance to eliminate the duplicate code in Edge and Chrome
  3. Allow Custom Browser Bookmark

TODO:

  • Localization
  • Detect bookmark file change
  • Version Bump

@taooceros taooceros self-assigned this Sep 23, 2021
@taooceros
Copy link
Member Author

taooceros commented Sep 23, 2021 •
edited
Loading

@Positron010 I have implemented the custom chromium bookmark loader. Do you want to take a try on this pr? You may need to figure out the data directory of the Vivaldi browser by yourself.

https://ci.appveyor.com/api/buildjobs/4kkg365luq1mcqru/artifacts/Output%2FPackages%2FFlow-Launcher-Setup.exe

@Positron010
Copy link

Hi @taooceros,
I just tried the build and it works well for me. Thanks for implementing it.

@taooceros
Copy link
Member Author

Hi @taooceros,
I just tried the build and it works well for me. Thanks for implementing it.

Nice to hear that!

@taooceros taooceros marked this pull request as ready for review September 25, 2021 01:08
@jjw24 jjw24 added the enhancement New feature or request label Sep 26, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Sep 26, 2021
jjw24
jjw24 requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. can we align the controls please
  2. why the two dummy entries?
  3. can we instead of 'CustomBrowsers', call it 'Load Bookmarks From:' or something else to distinguish from the control above that sets which browser to open bookmarks with.
    image

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Commands/BookmarkLoader.cs Outdated

var allBookmarks = new List<Bookmark>();

//TODO: Let the user select which browser's bookmarks are displayed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//TODO: Let the user select which browser's bookmarks are displayed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue #527 exists for this, lets remove the todo

@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Sep 26, 2021
@jjw24
Copy link
Member

jjw24 commented Sep 26, 2021

version bump please

@taooceros
Copy link
Member Author

version bump please

Always forget it😂

@taooceros
Copy link
Member Author

I will leave #688 in another branch

@taooceros taooceros requested a review from jjw24 October 9, 2021 18:05
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 11, 2021
@jjw24 jjw24 merged commit 8a33bf4 into dev Oct 11, 2021
@jjw24 jjw24 deleted the BrowserBookmarkRefactor branch October 11, 2021 21:43
@jjw24 jjw24 mentioned this pull request Oct 12, 2021
Merged
@jjw24 jjw24 mentioned this pull request Dec 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@taooceros taooceros

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Bookmark Search Configuration

3 participants

@taooceros @Positron010 @jjw24