Skip to content

Conversation

taooceros
Copy link
Member

No description provided.

@taooceros
Copy link
Member Author

I don't understand what's going wrong here......Let me investigate more

@taooceros
Copy link
Member Author

taooceros commented Oct 5, 2021

wtf is happening. I am able to add the submodule with linux but not with windows?
ok....the issue looks like to be the path being started by .\\, which is created by autocomplete.

@taooceros taooceros requested review from JohnTheGr8 and jjw24 October 5, 2021 04:52
@taooceros
Copy link
Member Author

Idea about the submodule? @Flow-Launcher/team

@jjw24
Copy link
Member

jjw24 commented Oct 5, 2021

Hey sorry haven't got around to look at this yet.

Why r we adding it as a sub module?

We can merge that repo in as a plugin folder first, keeping all commits history then merge into control panel or merge control panel into windows settings.

@taooceros let me know if u want me to take care of merging once the plugin is ready.

@taooceros
Copy link
Member Author

Yeah just do it. It should be ready except the glyph results. and #716

@taooceros
Copy link
Member Author

I just want to try submodule, but it seems bringing too much extra burden.

@jjw24
Copy link
Member

jjw24 commented Oct 9, 2021

closing, go to #741

@jjw24 jjw24 closed this Oct 9, 2021
@jjw24 jjw24 deleted the AddWindowsSettingsPlugin branch October 9, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants