-
-
Notifications
You must be signed in to change notification settings - Fork 446
Fix empty query #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty query #749
Conversation
it work only esc and toggle case. It doesn't work every visible/hidden case. |
what do you mean visible/hidden case? |
like 'open item' thing. In addition to esc and toggle hotkey, there are situations in which windows are closed. Anyway, looking at Power Toy, It was a similar way to me. I'll try copying it, but I don't know if it'll work out. If I success, I'll reopen. |
It's similar, just await 100ms before changing to collapse. They use Thread.Sleep(100), which I am not sure whether will cause a bit slow on closing. |
- add some opacity trick for empty query - remove start animation
- add some opacity trick for empty query - remove start animation
It was brought from powertoy to process toggle and updates. I think I fixed it. The opacity trick written above was also used. I fixed what I saw first. It does not work when the plug-in context menu is selected. I don't know where to fix this. |
The necessary methods were moved, and the redundant ones were erased. ESC and toggle use same method in now. |
Hm why all hotkey mapper method is moved to mainviewmodel? Previously #565 extract those method related to hotkey from mainviewmodel to hotkey mapper. I don't think we should move it back. I can handle the rest of the refactor if you think sometimes you encounter trouble in using the method across classes. |
I didn't see that issue discussion. I didn't know why this was separated. I just thought the empty query method should be separated from hotkey. I thought it was intuitive to be by the window. Anyway, I referred to Power Toy. They probably organized the code better than me. I focused on changing window hiding to a unified method. I just moved what was called together while moving the import empty query. If there seems to be a problem, you can correct it. As you know, I don't know how to structure it. |
@onesounds Please check the last commit, and if you think it works as expected, I will merge it. |
for Fix the #735 issue.
Why it happen.
so...
force update using Dispatcher
https://stackoverflow.com/questions/1644079/change-wpf-controls-from-a-non-main-thread-using-dispatcher-invoke
It is too difficult for me.
Using Opacity?
It is my solution
When I tested it, it worked well. feel so good.
problem
you guys will be able to trimmed more neatly.