Skip to content

Conversation

onesounds
Copy link
Contributor

Plan

  • It integrates browser settings of all web-related plugins into default settings.
  • If necessary, make private mode available.
    • Currently, there are only two on/off configurations, but it would be nice if factors could be added and used only when necessary. (e.g google.com-p)

image

@jjw24
Copy link
Member

jjw24 commented Nov 15, 2021

could we resolve conflict on this one please @taooceros @onesounds

@onesounds
Copy link
Contributor Author

This pr has not been completed and old. It was created only to create a setting window and pass the work to @taooceros. I thought it would be done quickly because it was a similar type of work to the file manager, but I close it first. taooceros is so busy.

@onesounds onesounds closed this Nov 15, 2021
@taooceros
Copy link
Member

Lol don't close it. I can do it today🤣

@onesounds
Copy link
Contributor Author

oh, is it possible? I don't know it's good UI. because other programs has no that option. they actually works based on OS setting. We actually only need private mode or new window/new tab.

@onesounds onesounds reopened this Nov 15, 2021
@taooceros
Copy link
Member

oh, is it possible? I don't know it's good UI. because other programs has no that option. they actually works based on OS setting. We actually only need private mode or new window/new tab.

I actually thinking about something like per profile browsering, but that may be a bit overkill?

@onesounds
Copy link
Contributor Author

onesounds commented Nov 15, 2021

I actually thinking about something like per profile browsering, but that may be a bit overkill?

It seems that we need a profile to use private mode easily. If there's no other opinion, let's just do this.

@onesounds onesounds added the enhancement New feature or request label Nov 16, 2021
@onesounds onesounds added this to the 1.9.0 milestone Nov 16, 2021
@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 17, 2021
@jjw24
Copy link
Member

jjw24 commented Dec 8, 2021

  • The new tab/window toggle is still switching around when I open the browser setting

  • private mode doesn't seem to be working

  • @taooceros for some reason the GitHub plugin fails to open the repo via url ('pressing ctrl + enter on the repo result')

@jjw24
Copy link
Member

jjw24 commented Dec 8, 2021

private mode doesn't seem to be working

working now

@jjw24
Copy link
Member

jjw24 commented Dec 8, 2021

@taooceros for some reason the GitHub plugin fails to open the repo via url ('pressing ctrl + enter on the repo result')

sorted

@jjw24
Copy link
Member

jjw24 commented Dec 9, 2021

remaining two:

  1. url open with auto suggestion doesnt work
  2. firefox new window with private wrong work (just open private window without url. )

@onesounds
Copy link
Contributor Author

ok. firefox is fine now. Sometimes it looks like a problematic movement, but it is a situation created by Firefox. It's not about us.

@onesounds
Copy link
Contributor Author

url open with auto suggestion works. confirmed.

Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work everyone!

@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Dec 9, 2021
@jjw24 jjw24 merged commit 037e0f8 into Flow-Launcher:dev Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants