-
-
Notifications
You must be signed in to change notification settings - Fork 445
Global browser setting / Private mode option #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
could we resolve conflict on this one please @taooceros @onesounds |
This pr has not been completed and old. It was created only to create a setting window and pass the work to @taooceros. I thought it would be done quickly because it was a similar type of work to the file manager, but I close it first. taooceros is so busy. |
Lol don't close it. I can do it today🤣 |
oh, is it possible? I don't know it's good UI. because other programs has no that option. they actually works based on OS setting. We actually only need private mode or new window/new tab. |
I actually thinking about something like per profile browsering, but that may be a bit overkill? |
It seems that we need a profile to use private mode easily. If there's no other opinion, let's just do this. |
…cher into GlobalBrowserSetting
Remove Releated code (just for build) Adjust Bookmark plugin popup layout and add string
Co-authored-by: Jeremy Wu <[email protected]>
Co-authored-by: Jeremy Wu <[email protected]>
Co-authored-by: Jeremy Wu <[email protected]>
…el.cs Co-authored-by: Jeremy Wu <[email protected]>
…el.cs Co-authored-by: Jeremy Wu <[email protected]>
Co-authored-by: Jeremy Wu <[email protected]>
|
working now |
sorted |
remaining two:
|
ok. firefox is fine now. Sometimes it looks like a problematic movement, but it is a situation created by Firefox. It's not about us. |
url open with auto suggestion works. confirmed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work everyone!
Plan