Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Nov 10, 2021

with the new modern ui coming, time to refresh the default theme used in the new install

let me know if there is another theme you feel more appropriate @Flow-Launcher/team

@jjw24 jjw24 added the enhancement New feature or request label Nov 10, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 10, 2021
@jjw24 jjw24 self-assigned this Nov 10, 2021
@jjw24 jjw24 enabled auto-merge November 10, 2021 20:21
onesounds
onesounds previously approved these changes Nov 10, 2021
@jjw24 jjw24 disabled auto-merge November 10, 2021 20:23
Garulf
Garulf previously approved these changes Nov 11, 2021
Copy link
Member

@Garulf Garulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@jjw24 jjw24 dismissed stale reviews from Garulf and onesounds via 78fafab November 11, 2021 09:41
@jjw24 jjw24 enabled auto-merge November 11, 2021 09:42
@Garulf
Copy link
Member

Garulf commented Nov 12, 2021

I think going forward @onesounds's. Win11light theme is very appropriate as the new default. It'll be a better match to the new settings menu so it's less jarring to newcomers.

@Zeroto521
Copy link
Member

Zeroto521 commented Nov 12, 2021

Are there any pictures about this new theme?
I'd like to get preview about it.

@jjw24
Copy link
Member Author

jjw24 commented Nov 12, 2021

Current:
image

Proposed:
image

@Zeroto521
Copy link
Member

An idea about light and dark themes.
What if they could automated switch based on system light and dark mode?

@jjw24
Copy link
Member Author

jjw24 commented Nov 12, 2021

Yeah that'd be nice, for think the library we r using offers this maybe.

Seems like you all cool with this, can some one approve this lol

@onesounds
Copy link
Contributor

Both Dark and Light versions are included in dev.
Dark mode (base OS setting) is on the Plan, and related codes were also investigated. It is not difficult, but it is planned to be done later due to its large workload and low priority. It is difficult at 1.9.

@jjw24 jjw24 merged commit 1ab9c08 into dev Nov 12, 2021
@jjw24 jjw24 deleted the change_default_theme branch November 12, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants