Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 27, 2021

#761
#734

This pr contains the following.

  • Add Hide Apps Path setting (UWP / *.lnk). Default is "True"

  • Change string "Enable Program Description" to "Search in Program Description"
  • Change "Search in Program Description" default setting to "False" from "true"
    • If necessary, it is useful, but not necessary for general use, and it is recommended not to activate it by default because there is a problem that the name of the item is prolonged.
  • Adjust Popup Window Design and color
  • Dark mode pr is merged.

Additional work is needed, but it is difficult for me to do.

  • The Hide Apps Path setting does not change in real time. When changing the setting, it must be changed in real time.
  • The list view style is not applied. When applied, it is displayed as follows. There is a need for a way to come out properly when applied. Since the existing state has a problem in dark mode, it is necessary to apply the style.

Broken Style (Default)
image

Applied Style
image

@onesounds onesounds self-assigned this Nov 27, 2021
@onesounds onesounds added enhancement New feature or request kind/ui related to UI, icons, themes, etc labels Nov 27, 2021
@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 29, 2021

public bool EnableDescription { get; set; } = true;
public bool EnableDescription { get; set; } = false;
public bool EnableHideLnkPath { get; set; } = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like this variable should be EnableHideAppPath because you are hiding not only Lnk but also could be the file path to the app executable right?

Copy link
Contributor Author

@onesounds onesounds Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I'll change it.

@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 29, 2021
@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Nov 30, 2021
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 30, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 30, 2021
@jjw24 jjw24 merged commit 96bcf1b into Flow-Launcher:dev Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants