Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Nov 29, 2021

Switch off the default launch on system start up, user can set it if they wish to launch with system start up

@jjw24 jjw24 added the enhancement New feature or request label Nov 29, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 29, 2021
@jjw24 jjw24 self-assigned this Nov 29, 2021
@jjw24 jjw24 enabled auto-merge November 29, 2021 09:52
Copy link
Contributor

@onesounds onesounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👼

@jjw24 jjw24 merged commit d8773b8 into dev Nov 29, 2021
@jjw24 jjw24 deleted the disable_startup_default branch November 29, 2021 11:27
@jjw24
Copy link
Member Author

jjw24 commented Nov 29, 2021

I think usually programs do not auto start by default and i personally wouldnt also want any program to auto start unless i tell it to. This is also the case especially if it is portable. Auto start means editing the registry, so not everyone is fond of having a program do that without explicit permission.

@onesounds
Copy link
Contributor

I think usually programs do not auto start by default and i personally wouldnt also want any program to auto start unless i tell it to. This is also the case especially if it is portable. Auto start means editing the registry, so not everyone is fond of having a program do that without explicit permission.

I think usually programs do not auto start by default and i personally wouldnt also want any program to auto start unless i tell it to. This is also the case especially if it is portable. Auto start means editing the registry, so not everyone is fond of having a program do that without explicit permission.

How about put the setting in 'welcome screen'? it will showing when first launch. surely, default is uncheck.

@Garulf
Copy link
Member

Garulf commented Nov 29, 2021

I think usually programs do not auto start by default and i personally wouldnt also want any program to auto start unless i tell it to. This is also the case especially if it is portable. Auto start means editing the registry, so not everyone is fond of having a program do that without explicit permission.

Sorry deleted my comment due to some confusion... Yeah I guess that makes sense.

I think @onesounds welcome screen idea will be the best "fix" for giving a new User the option.

@jjw24
Copy link
Member Author

jjw24 commented Nov 30, 2021

Putting in welcome screen is great idea @onesounds

@onesounds
Copy link
Contributor

Okay. I think I can work quickly because I used to make something before. Let's release 1.9 within this week and include its features.

@onesounds onesounds mentioned this pull request Dec 1, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants