Skip to content

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 29, 2021

Old
image

New
app_missing_img

  • Change Design
  • Resize to 48x48

It is an icon that you often see when you use it, but the file size is larger than other icons and it looks ugly in recent designs, so I replace it.

p.s It's not the source from online.

@onesounds onesounds added enhancement New feature or request kind/ui related to UI, icons, themes, etc labels Nov 29, 2021
@onesounds onesounds self-assigned this Nov 29, 2021
@jjw24
Copy link
Member

jjw24 commented Nov 29, 2021

hmm the new design looks a bit too plain ?

@onesounds
Copy link
Contributor Author

hmm the new design looks a bit too plain ?

old design is not good. I put in the window(small 4 square) and tested it. but plain is better.

@jjw24
Copy link
Member

jjw24 commented Nov 30, 2021

When you say not good, r you talking aesthetic wise?

The new look looks a bit 'too old school broken', I think put something in there to lighten it up feels a bit more eye pleasing, doesn't have to be four windows, just something easy and light-hearted on the eyes was what the old design was going for. Like these days with browser response errors.

@onesounds
Copy link
Contributor Author

onesounds commented Nov 30, 2021

When you say not good, r you talking aesthetic wise?

The new look looks a bit 'too old school broken', I think put something in there to lighten it up feels a bit more eye pleasing, doesn't have to be four windows, just something easy and light-hearted on the eyes was what the old design was going for. Like these days with browser response errors.

Yes, I'm talking from a design point of view. This icon has been my concern since the beginning of flow use. I would have designed it like your words if it was seen simply in the absence of an icon, but this icon is often seen when scrolling. isn't it? (Maybe it's because icon didn't load.) You're right if flow don't show the icon at all when it's not loaded, and only show if icon really doesn't exist.

It is difficult to say that the error icon is also a good icon. Personally, icons that have come down since the days of wox are not bad, but they are far from modern design and give a feeling that the software is old. If it was the same theme as before, it would be no problem, but it is not an appropriate icon in a modernized design change as it is now.

@onesounds
Copy link
Contributor Author

Anyway, there seems to be a disagreement because this icon is used interchangeably in two situations.

  1. icon does not exist (you)
  2. temporary icon that before the icon is loaded. (me)

Can we make completely distinguish between the temporary icon and the case where the icon does not exist? If we can, I can create a few more icons corresponding to your words.

@jjw24
Copy link
Member

jjw24 commented Nov 30, 2021

Ok, thanks for explaining, yep makes sense. If you can, that would be great.

@onesounds
Copy link
Contributor Author

Ok, thanks for explaining, yep makes sense. If you can, that would be great.

yep, but not now. I'll do first welcome window.

@onesounds onesounds closed this Dec 3, 2021
@onesounds onesounds reopened this Dec 3, 2021
@taooceros
Copy link
Member

temporary icon that before the icon is loaded. (me)

yes that's under expected. It's added in #195

@onesounds
Copy link
Contributor Author

onesounds commented Dec 6, 2021

how about change all the icons? (from icon8.com's fluenticon)

image
image
image
image
image
image
image

@jjw24
Copy link
Member

jjw24 commented Dec 6, 2021

how about change all the icons? (from icon8.com's fluenticon)

yeah sounds good

Add icons8.com link in about
jjw24
jjw24 previously approved these changes Jan 19, 2022
jjw24
jjw24 previously approved these changes Jan 19, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Jan 19, 2022
@jjw24 jjw24 enabled auto-merge January 19, 2022 10:36
@jjw24 jjw24 merged commit 0e9830d into Flow-Launcher:dev Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request kind/ui related to UI, icons, themes, etc

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants