-
-
Notifications
You must be signed in to change notification settings - Fork 448
Implement PluginSearch TextBox & ContentControl Lazy Load #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks like it's still WIP? i will mark it as draft |
search is not working, tried pressing enter too. |
works for me. What's your behavior? |
Tried it again and still the Plugin Store's search is not working. I removed entire flow user data then rebuilt and ran. Went into plugin store tab and clicked on the search text, put in a search term 'colors' and pressed enter. Nothing happens. Search is however working for me in the plugins tab. Also:
|
Ah I get your idea🤣I haven't implemented the plugin store search. I will fix that later. |
# Conflicts: # Flow.Launcher/Languages/en.xaml
Oh we already have the lostfocus event. I don't want to filter while user typing because that will create unhappy typing experience. If later we find ways to optimize the render, we can revise the behavior. |
- enter in plugin list - ctrl+f for plugin store
this is ready for review? |
yep. There are 'installed' labels or a few more features I want to add, but I think it would be better to do it in another pr. The search itself works well. |
- Adjust Control Position
Uh oh!
There was an error while loading. Please reload this page.