Skip to content

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Dec 11, 2021

  • Plugin store search
  • Ctrl + F when in the plugin store page to focus cursor on the search box
  • Plugins tab search

@onesounds onesounds added the enhancement New feature or request label Dec 12, 2021
@jjw24 jjw24 added review in progress Indicates that a review is in progress for this PR and removed review in progress Indicates that a review is in progress for this PR labels Dec 19, 2021
@jjw24
Copy link
Member

jjw24 commented Dec 19, 2021

looks like it's still WIP? i will mark it as draft

@jjw24 jjw24 marked this pull request as draft December 19, 2021 09:44
@taooceros taooceros marked this pull request as ready for review February 6, 2022 23:50
@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Feb 7, 2022
@jjw24
Copy link
Member

jjw24 commented Feb 7, 2022

search is not working, tried pressing enter too.

@taooceros
Copy link
Member Author

search is not working, tried pressing enter too.

works for me. What's your behavior?

@jjw24
Copy link
Member

jjw24 commented Feb 13, 2022

Tried it again and still the Plugin Store's search is not working. I removed entire flow user data then rebuilt and ran. Went into plugin store tab and clicked on the search text, put in a search term 'colors' and pressed enter. Nothing happens.

Search is however working for me in the plugins tab.

Also:

  • can we add Ctrl + F focus to the Plugin Store search text box please
  • add a tooltip to both tabs so when hovering over the search text box it displays something like 'Ctrl + F to search plugins'

@taooceros
Copy link
Member Author

Tried it again and still the Plugin Store's search is not working. I removed entire flow user data then rebuilt and ran. Went into plugin store tab and clicked on the search text, put in a search term 'colors' and pressed enter. Nothing happens.

Search is however working for me in the plugins tab.

Also:

* can we add Ctrl + F focus to the Plugin Store search text box please

* add a tooltip to both tabs so when hovering over the search text box it displays something like 'Ctrl + F to search plugins'

Ah I get your idea🤣I haven't implemented the plugin store search. I will fix that later.

@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Feb 13, 2022
@jjw24 jjw24 marked this pull request as draft February 13, 2022 23:10
@github-actions github-actions bot added the Stale label Jun 5, 2022
@taooceros taooceros marked this pull request as ready for review June 30, 2022 13:47
@taooceros
Copy link
Member Author

Oh we already have the lostfocus event. I don't want to filter while user typing because that will create unhappy typing experience. If later we find ways to optimize the render, we can revise the behavior.

- enter in plugin list
- ctrl+f for plugin store
@jjw24
Copy link
Member

jjw24 commented Sep 27, 2022

this is ready for review?

@onesounds
Copy link
Contributor

this is ready for review?

yep. There are 'installed' labels or a few more features I want to add, but I think it would be better to do it in another pr. The search itself works well.

@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Oct 5, 2022
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Oct 11, 2022
@jjw24 jjw24 added this to the 1.10.0 milestone Oct 11, 2022
@jjw24 jjw24 merged commit 3920574 into dev Oct 11, 2022
@jjw24 jjw24 deleted the PluginSearchTextBox branch October 11, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants