fix calling mainwindow animation after loaded #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taooceros were you able to replicate this issue? |
jjw24
reviewed
Dec 16, 2021
jjw24
added
the
review in progress
Sometimes |
|
there is an IsLoaded method attached to the mainwindow class if you want to actually check that the window is loaded. |
Co-authored-by: Jeremy Wu <[email protected]>
I will take al look |
Move animation and sound to MainWindow instead of MainViewModel
|
This way should solve the issue. The animation is called inside MainWindow, so no more potential of null reference. |
jjw24
force-pushed
the
FixNullReferenceError
branch
from
174793a to
58317b7
Compare
jjw24
approved these changes
Dec 20, 2021
jjw24
removed
the
review in progress
jjw24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #902
It's a fix that prevent the error. It looks like it's because mainwindow takes too long to be created and assigned, which results in the issue. We need to investigate that in the future.