Add offset to suggestion text hide calculation #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you send me a string to test, i cant replicate what you got in the screenshot. |
jjw24
reviewed
Dec 19, 2021
It's tricky because the text has to be just at the cut off after you tab complete it.
Offset is adjustable in settings file. Not sure if it's really needed in GUI. EDIT: Which I'm now realizing is not what you meant... I would need to some how grab the right-padding being set by the theme on the |
jjw24
reviewed
Dec 20, 2021
jjw24
reviewed
Dec 20, 2021
|
Able to replicate with current release 1.9.0:
|
jjw24
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a slight offset to the comparison of Rendered text and text box length.
Before:
After:
