Skip to content

Conversation

taooceros
Copy link
Member

No description provided.

@jjw24
Copy link
Member

jjw24 commented Dec 19, 2021


<!-- Settings -->
<system:String x:Key="BookmarkDataSetting">Bookmmark Data</system:String>
<system:String x:Key="BookmarkDataSetting">Bookmark Data</system:String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however this name does not conform with others, may have a slight chance to cause clash. let's use this pr to fix

@jjw24 jjw24 changed the title fix bookmark string Fix BookmarkDataSetting key string Dec 19, 2021
@jjw24 jjw24 added the bug Something isn't working label Dec 19, 2021
@jjw24 jjw24 added this to the 1.9.1 milestone Dec 19, 2021
@jjw24 jjw24 enabled auto-merge December 19, 2021 21:49
@jjw24 jjw24 merged commit c9727ea into dev Dec 19, 2021
@jjw24 jjw24 deleted the fixSourceString branch December 19, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants