Skip to content

Fix typescript plugin request #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Fix typescript plugin request #927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53760b
formatting
jjw24 Dec 22, 2021
bf0e4ba
fix Executable plugin's JsonRPC request string
jjw24 Dec 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Flow.Launcher.Core/Plugin/ExecutablePlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System;
using System.Diagnostics;
using System.Diagnostics;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand All @@ -22,18 +21,23 @@ public ExecutablePlugin(string filename)
RedirectStandardOutput = true,
RedirectStandardError = true
};

// required initialisation for below request calls
_startInfo.ArgumentList.Add(string.Empty);
}

protected override Task<Stream> RequestAsync(JsonRPCRequestModel request, CancellationToken token = default)
{
_startInfo.Arguments = $"\"{request}\"";
// since this is not static, request strings will build up in ArgumentList if index is not specified
_startInfo.ArgumentList[0] = request.ToString();
return ExecuteAsync(_startInfo, token);
}

protected override string Request(JsonRPCRequestModel rpcRequest, CancellationToken token = default)
{
_startInfo.Arguments = $"\"{rpcRequest}\"";
// since this is not static, request strings will build up in ArgumentList if index is not specified
_startInfo.ArgumentList[0] = rpcRequest.ToString();
return Execute(_startInfo);
}
}
}
}