Skip to content

Conversation

taooceros
Copy link
Member

@taooceros taooceros commented Dec 23, 2021

  1. Expandable Shortcut
  2. Built-in variables- {clipboard} for accessing latest clipboard entry

@jjw24 jjw24 marked this pull request as draft January 19, 2022 10:05
@taooceros taooceros marked this pull request as ready for review March 26, 2022 16:27
@taooceros
Copy link
Member Author

Do we want to reference to variable? So probably a later shortcut can reference back to an earlier shortcut (then we need a move up and move down button).

@taooceros
Copy link
Member Author

It will be interesting if we introduce variable like {{clipboard}}

@taooceros taooceros self-assigned this May 31, 2022
@taooceros taooceros added the enhancement New feature or request label May 31, 2022
@taooceros taooceros added this to the 1.10.0 milestone May 31, 2022
@taooceros taooceros requested a review from jjw24 June 4, 2022 05:30
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The title and subtitle of the query shortcut config window need to be changed.
  • Please add preview button so it's consistent with custom query hotkey
  • Change the name 'Shortcut' to 'Custom Query Shortcut' so it's consistent.

image

@jjw24 jjw24 added the review in progress Indicates that a review is in progress for this PR label Jun 5, 2022
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortcut is not being saved.

@jjw24
Copy link
Member

jjw24 commented Jun 5, 2022

is this how you would use env variables?

image

@jjw24 jjw24 enabled auto-merge June 5, 2022 10:52
@jjw24 jjw24 changed the title Draft Query Shortcut Custom Query Shortcut Jun 5, 2022
@jjw24
Copy link
Member

jjw24 commented Nov 6, 2022

What plans do we have for adding built in variables apart from clipboard?

@VictoriousRaptor
Copy link
Contributor

What plans do we have for adding built in variables apart from clipboard?

Not yet.

@jjw24
Copy link
Member

jjw24 commented Nov 6, 2022

Explorer plugin doesn't play well with {, getting exception when I type {cli, need to fix that in Explorer.

@jjw24
Copy link
Member

jjw24 commented Nov 6, 2022

What plans do we have for adding built in variables apart from clipboard?

Not yet.

So what else can we do with this functionality? Clipboard access can be done better with the Clipboard plugin I feel.

@VictoriousRaptor
Copy link
Contributor

Explorer plugin doesn't play well with {, getting exception when I type {cli, need to fix that in Explorer.

Maybe it is related to the vscode workspace plugin (default action word {). I remember I had similar issues when testing along with the plugin.

What plans do we have for adding built in variables apart from clipboard?

Not yet.

So what else can we do with this functionality? Clipboard access can be done better with the Clipboard plugin I feel.

This design is to provide functionality more than simple static string replacment. I don't have any good idea about what else we can do with it yet.

@jjw24
Copy link
Member

jjw24 commented Nov 6, 2022

Maybe it is related to the vscode workspace plugin (default action word {). I remember I had similar issues when testing along with the plugin.

Nah, actually reproducible with Dev branch.

@jjw24
Copy link
Member

jjw24 commented Nov 6, 2022

This design is to provide functionality more than simple static string replacment. I don't have any good idea about what else we can do with it yet.

Feels like half-baked at the moment because users wouldn't be able to add new ones in and clipboard access can be done with the clipboard plugin. What about pulling it out to a separate pr?

@VictoriousRaptor
Copy link
Contributor

This design is to provide functionality more than simple static string replacment. I don't have any good idea about what else we can do with it yet.

Feels like half-baked at the moment because users wouldn't be able to add new ones in and clipboard access can be done with the clipboard plugin. What about pulling it out to a separate pr?

Maybe we should discuss it later, when other problems of this pr are fixed.

@jjw24 jjw24 changed the title Custom Query Shortcut Custom Query Shortcut + built-in variables Nov 7, 2022
@jjw24 jjw24 enabled auto-merge November 7, 2022 21:58
@jjw24 jjw24 removed the review in progress Indicates that a review is in progress for this PR label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants