Auto re-index for Program and Bookmark plugins #967
Conversation
Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs
Outdated
Show resolved
Hide resolved
Plugins/Flow.Launcher.Plugin.BrowserBookmark/Commands/BookmarkLoader.cs
Outdated
Show resolved
Hide resolved
Plugins/Flow.Launcher.Plugin.BrowserBookmark/FirefoxBookmarkLoader.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public static void WatchPackageChange() | ||
| { | ||
| if (Environment.OSVersion.Version.Build >= 19041) |
There was a problem hiding this comment.
Same to uwp apps. Probably using main version higher than 10 is also good.
There was a problem hiding this comment.
sorry i am not following, main version as in Windows 10? why higher than 10 is good though?
| if (!(_win32s.Any() && _uwps.Any())) | ||
| await indexTask; | ||
|
|
||
| Win32.WatchProgramUpdate(_settings); |
There was a problem hiding this comment.
do you not also need to add WatchProgramUpdate for UWP apps?
There was a problem hiding this comment.
Huh I forget? I will check soon.
There was a problem hiding this comment.
Ah no. UWP are watched by package update
|
Lets remove this mechanism now that we are adding the watcher in. |
jjw24
added
the
review in progress
Should we reindex on startup at background? |
Finally get some workable free time. I will check now. |
|
The firefox bookmark works partially when the bookmark is added to bookmark folder that is not the bookmark tool bar? I don't know how firefox handle that but if the bookmark is added to the toolbar, the sqlite file won't change. |
|
@jjw24 I forget to reset cache when reindex. Now it should work (at least work for uwp). |
There was a problem hiding this comment.
So after testing with the latest changes I am finding:
- Chrome bookmarks work
- Edge bookmarks work
- Installing & removing Win32 apps work
- Apps (UWP) installed from Microsoft Store do not work
- Firefox boomarks does not work at all
@taooceros getting close :)
|
@jjw24 what's your uwp version? We are using a relatively new winrt api so probably that won't work in earlier version? (just similar to the windows notification) |
jjw24
removed
the
review in progress
|
I tested with Snip & Sketch via Microsoft's App Store. Does it work for you? What UWP app did you test? |
Sorry I mean the windows version. |
I test it with netflix. |
|
Would you mind take a debug on whether the events are triggered if that doesn't work? |
|
I wonder probably we can make the reindex faster by deleting the uninstalled entry/adding new entry. But the current way is good enough for now since it is unlikely that it will requires a lot of resources. |
jjw24
added
the
review in progress
With Firefox (v104.0) bookmarks, I have found when a bookmark is added or removed, the surest way that places.sqlite will get updated is when you close all Firefox browser. Occasionally it may update after adding/ removing a bookmark. Chrome and Edge on the other hand their file get updated almost instantly after adding/removing a bookmark. This is fine with Firefox as it is beyond our control when the places.sqlite file get updated. |
|
Tested on Windows [Version 10.0.19044.1949]:
|
jjw24
changed the title
jjw24
removed
the
review in progress
3 participants
Watch Program and Bookmark file changes to trigger re-index
Tested on Windows [Version 10.0.19044.1949]:
Close #688 #1336