Skip to content

Conversation

taooceros
Copy link
Member

It is creating too much warning in the log file because of translation. No need for the warning because it is simply the resources doesn't exist.

@onesounds onesounds added the enhancement New feature or request label Jan 10, 2022
@jjw24
Copy link
Member

jjw24 commented Jan 10, 2022

Should we perhaps change it to if debug to log when only debugging? Would there be a case where we need to determine why a resource is not loaded?

Also plugin version bump please

@jjw24 jjw24 added this to the 1.10.0 milestone Jan 10, 2022
@taooceros
Copy link
Member Author

Should we perhaps change it to if debug to log when only debugging? Would there be a case where we need to determine why a resource is not loaded?

Also plugin version bump please

Generally it is simply because of the translation doesn't exist, which should be totally fine. We cannot distinguish this from other reason because it is simply return null.

@taooceros taooceros requested a review from jjw24 January 13, 2022 23:40
@taooceros
Copy link
Member Author

taooceros commented Jan 13, 2022

wait a moment. If it's translation issue, shouldn't be so much resources can't be found. I will check again. especially when using english

@taooceros
Copy link
Member Author

huh those strings are for control panel (probably for task link added by @pc223 ) I remember he adds the translation for that previously. We can add that first.

@jjw24
Copy link
Member

jjw24 commented Jan 14, 2022

huh those strings are for control panel (probably for task link added by @pc223 ) I remember he adds the translation for that previously. We can add that first.

I thought we included his changes already

@taooceros
Copy link
Member Author

huh those strings are for control panel (probably for task link added by @pc223 ) I remember he adds the translation for that previously. We can add that first.

I thought we included his changes already

well mostly, but the translation is not yet finished or being delayed because of some reason, so we forget about that or decide to delay it in the future.

@jjw24
Copy link
Member

jjw24 commented Jan 18, 2022

I remember he adds the translation for that previously. We can add that first.

I wasnt too invovled with the PR/changes, do you know where we can find the translations he added previously?

@taooceros
Copy link
Member Author

I remember he adds the translation for that previously. We can add that first.

I wasnt too invovled with the PR/changes, do you know where we can find the translations he added previously?

https://github.com/pc223/MSWindowsControlPanelTaskLinks
he has added part of that here

@jjw24 jjw24 marked this pull request as draft January 27, 2022 03:52
@taooceros
Copy link
Member Author

I will fix the resources by adding a english one first

…me to match the culture we use; Adjust some of the key name; Put Tasklink item into culture
@taooceros taooceros marked this pull request as ready for review June 11, 2022 07:46
@taooceros taooceros requested review from jjw24 and removed request for jjw24 June 11, 2022 08:10
@taooceros taooceros changed the title Remove WindowsSetting resource not found warning Move Tasklink Name into Resource (except altName) Jun 11, 2022
Make Tasklink Area Unknown
Make Tasklink results score lower
@taooceros taooceros changed the title Move Tasklink Name into Resource (except altName) Move Tasklink Name into Resource (except altName) & Glyph Icon Support Jun 11, 2022
@jjw24 jjw24 enabled auto-merge July 17, 2022 20:39
@jjw24 jjw24 merged commit 6abd37d into dev Jul 17, 2022
@jjw24 jjw24 deleted the windowsSettingtranslationWarning branch July 17, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants