-
-
Notifications
You must be signed in to change notification settings - Fork 453
Move Tasklink Name into Resource (except altName) & Glyph Icon Support #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we perhaps change it to Also plugin version bump please |
Generally it is simply because of the translation doesn't exist, which should be totally fine. We cannot distinguish this from other reason because it is simply return null. |
wait a moment. If it's translation issue, shouldn't be so much resources can't be found. I will check again. especially when using english |
huh those strings are for control panel (probably for task link added by @pc223 ) I remember he adds the translation for that previously. We can add that first. |
I thought we included his changes already |
well mostly, but the translation is not yet finished or being delayed because of some reason, so we forget about that or decide to delay it in the future. |
I wasnt too invovled with the PR/changes, do you know where we can find the translations he added previously? |
https://github.com/pc223/MSWindowsControlPanelTaskLinks |
I will fix the resources by adding a english one first |
…me to match the culture we use; Adjust some of the key name; Put Tasklink item into culture
Make Tasklink Area Unknown Make Tasklink results score lower
It is creating too much warning in the log file because of translation. No need for the warning because it is simply the resources doesn't exist.