-
-
Notifications
You must be signed in to change notification settings - Fork 36
Fix tests on 1.8 #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests on 1.8 #128
Conversation
Pull Request Test Coverage Report for Build 2898925212
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 70.67% 71.38% +0.70%
==========================================
Files 9 9
Lines 648 657 +9
==========================================
+ Hits 458 469 +11
+ Misses 190 188 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
If you're running tests with >1 threads, that's a long-standing NNlib issue and I'm not sure where it comes from :( |
Pull Request Test Coverage Report for Build 2897172302Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 2897172302Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
For #125, this replaces the method definitions for
catfunctions with slightly less crazy loops, which have fewer ambiguities. In anycat(A,B,Cs...), one of the first two must be a tracked type, no longer one of the first 3, as this shortens the list.The other failure was
depthwiseconv. This is depends on the random number seed, it doesn't consistently fail, I have not investigated whether this is a numerical problem or a gradient problem.