Use futures efficiently #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FractalBoy
force-pushed
the
use-futures-efficiently
branch
from
a7d4931 to
6730db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than peppering code with calls to
Future->retain(), this returns a future back to the server for it to await.In some cases, returning a future would be too difficult, so we call
->getor->awaitto get the result.Additionally, now that we can return a future to the server, it should be able to process requests that have already been read into the read buffer faster (and present in
$buffref), since calling->getor->awaitwill only return control to the main server read function when there is more data to be read (not when the data has already been read but not parsed).