Add Allam cycle module #772

qluo0320github · 2024-09-19T18:25:28Z

Description

This module adds a new resource "Allam Cycle with Oxygen Storage" to GenX.
An allam cycle includes three components: sCO2 turbine, air separation unit, and liquid O2 storage. Each of them is subject to its own investment decisions and operational constraints.

What type of PR is this? (check all applicable)

Feature

Related Tickets & Documents

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Using the new example case "three_zone_w_allam_cycle_lox"

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

cfe316 · 2024-09-20T15:41:55Z

src/write_outputs/write_allamcyclelox.jl

+	if setup["ParameterScale"] ==1
+		dfCapAllam.StartCap_sCO2turbine_MW_gross = dfCapAllam.StartCap_sCO2turbine_MW_gross* ModelScalingFactor
+		dfCapAllam.RetCap_sCO2turbine_MW_gross = dfCapAllam.RetCap_sCO2turbine_MW_gross * ModelScalingFactor
+		dfCapAllam.NewCap_sCO2turbine_MW_gross = dfCapAllam.NewCap_sCO2turbine_MW_gross * ModelScalingFactor
+		dfCapAllam.EndCap_sCO2turbine_MW_gross = dfCapAllam.EndCap_sCO2turbine_MW_gross * ModelScalingFactor
+
+		dfCapAllam.StartCap_ASU_MW_gross = dfCapAllam.StartCap_ASU_MW_gross* ModelScalingFactor
+		dfCapAllam.RetCap_ASU_MW_gross = dfCapAllam.RetCap_ASU_MW_gross * ModelScalingFactor
+		dfCapAllam.NewCap_ASU_MW_gross = dfCapAllam.NewCap_ASU_MW_gross * ModelScalingFactor
+		dfCapAllam.EndCap_ASU_MW_gross = dfCapAllam.EndCap_ASU_MW_gross * ModelScalingFactor
+
+		dfCapAllam.StartCap_LOX_t = dfCapAllam.StartCap_LOX_t * ModelScalingFactor
+		dfCapAllam.RetCap_LOX_t = dfCapAllam.RetCap_LOX_t * ModelScalingFactor
+		dfCapAllam.NewCap_LOX_t = dfCapAllam.NewCap_LOX_t * ModelScalingFactor
+		dfCapAllam.EndCap_LOX_t = dfCapAllam.EndCap_LOX_t * ModelScalingFactor
+	end


Consider using the scale_columns! function like you did in scale_allamcycle_data!.

cfe316 · 2024-09-20T15:43:16Z

src/write_outputs/write_allamcyclelox.jl

+	capAllam_sco2turbine = zeros(size(inputs["RESOURCE_NAMES"]))
+	capAllam_asu = zeros(size(inputs["RESOURCE_NAMES"]))
+	capAllam_lox = zeros(size(inputs["RESOURCE_NAMES"]))


Consider using G = inputs["G"] and then zeros(G) instead of size(inputs["RESOURCE_NAMES"]).

cfe316 · 2024-09-20T15:44:40Z

src/write_outputs/write_allamcyclelox.jl

+		[inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_sco2turbine_gross_power_mw";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_sco2turbine_commit";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_asu_gross_power_mw";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_asu_commit";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_net_power_output_mw";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_storage_lox_t";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_lox_in_t";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_lox_out_t";
+		inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] .*"_gox_t"])


Consider assigning a variable name like allam_resources = inputs["RESOURCE_NAMES"][ALLAM_CYCLE_LOX] for brevity.

cfe316 · 2024-09-20T17:36:08Z

src/model/resources/flexible_ccs/allamcycle_commit.jl

+            @constraints(EP, begin
+                # cUpTimeInterior: Constraint looks back over last n hours, where n = allam_dict[y, "up_time"][i])
+                [t in setdiff(INTERIOR_SUBPERIODS,Up_Time_HOURS)], vCOMMIT_Allam[y,i,t] >= sum(vSTART_Allam[y,i,e] for e=(t-allam_dict[y, "up_time"][i]):t)
+
+                # cUpTimeWrap: If n is greater than the number of subperiods left in the period, constraint wraps around to first hour of time series
+                # cUpTimeWrap constraint equivalant to: sum(vSTART_Allam[y,e] for e=(t-((t%hours_per_subperiod)-1):t))+sum(vSTART_Allam[y,e] for e=(hours_per_subperiod_max-(allam_dict[y, "up_time"][i])-(t%hours_per_subperiod))):hours_per_subperiod_max)
+                [t in Up_Time_HOURS], vCOMMIT_Allam[y,i,t] >= sum(vSTART_Allam[y,i,e] for e=(t-((t%hours_per_subperiod)-1):t))+sum(vSTART_Allam[y,i,e] for e=((t+hours_per_subperiod-(t%hours_per_subperiod))-(allam_dict[y, "up_time"][i]-(t%hours_per_subperiod))):(t+hours_per_subperiod-(t%hours_per_subperiod)))
+
+                # cUpTimeStart:
+                # NOTE: Expression t+hours_per_subperiod-(t%hours_per_subperiod) is equivalant to "hours_per_subperiod_max"
+                [t in START_SUBPERIODS], vCOMMIT_Allam[y,i,t] >= vSTART_Allam[y,i,t]+sum(vSTART_Allam[y,i,e] for e=((t+hours_per_subperiod-1)-(allam_dict[y, "up_time"][i]-1)):(t+hours_per_subperiod-1))
+            end)
+
+            ## down time
+            Down_Time = Int(floor(allam_dict[y, "down_time"][i]))
+            Down_Time_HOURS = [] # Set of hours in the summation term of the maximum down time constraint for the first subperiod of each representative period
+            for s in START_SUBPERIODS
+                Down_Time_HOURS = union(Down_Time_HOURS, (s+1):(s+Down_Time-1))
+            end


Here and elsewhere, consider using hoursbefore and hoursafter in order to simplify formulation of the constraints. It should be possible to write a single constraint over [t in 1:T].

cfe316 · 2024-09-20T17:38:03Z

src/model/resources/flexible_ccs/allamcycle_no_commit.jl

+    START_SUBPERIODS = inputs["START_SUBPERIODS"] #start
+    INTERIOR_SUBPERIODS = inputs["INTERIOR_SUBPERIODS"] #interiors


These two lines are not used in this function.

…d `eTotalCap`

lbonaldo

Thanks, @qluo0320github, for adding this new module and the documentation!

* Add Allam Cycle with Liquid Oxygen Storage * Add duration constraints on LOX of allam cycle * Add policy-related constraints to allam cycle; add UC * Add doc for Allam Cycle inputs * Add test for Allam Cycle module --------- Co-authored-by: Fangwei Cheng <[email protected]>

qluo0320github requested review from JesseJenkins and lbonaldo September 19, 2024 18:25

cfe316 reviewed Sep 20, 2024

View reviewed changes

lbonaldo added the enhancement New feature or request label Dec 3, 2024

lbonaldo added this to the v0.4.3 milestone Dec 4, 2024

lbonaldo force-pushed the allamcycle branch 4 times, most recently from 345eb8a to 27bed48 Compare January 24, 2025 23:08

lbonaldo force-pushed the allamcycle branch from 1c73d59 to 740cab9 Compare January 29, 2025 20:51

fc4uk and others added 16 commits February 9, 2025 16:56

add Allam Cycle with Liquid Oxygen Storage

f6e090c

fixed some typos and issues in scaling

c5605ad

fixed some issues when UC = 1

e01eef8

add duration constraints on LOX of allam cycle

86f066b

Remove vP for AllamCycle

c21c6b1

Add policy-related constraints to allam cycle; add UC

8587c4b

add LOX duration; add documentation of AC module

df651dc

Rewrite code for brevity in write_allamcycle.csv

745f38d

replace t-1 by hoursbefore function

d347d28

Fixed typos and remove redundant contents

b0b2788

fix bugs in writing AC capacity output

0d5a660

Fix indices in cStore_lox

0d114c5

Update write_capacityfactor to use eTotalCap_AllamcycleLOX instea…

0708151

…d `eTotalCap`

Update end_cap in write_capacity for allam cycle

f15f120

Add validation for Multistage=1 and allam cycle module

a70a154

Remove overwriting of AnnualSum for allamcycle in write_cf

b341b11

qluo0320github and others added 24 commits February 9, 2025 16:56

fix table numbers

6c1ba2a

Additional cleanup to module

55d71c8

Refactor contribution of Allam cycle to ESR

5e82002

Fix documentation

67f7732

Rename example system

06969ea

Update README.md for example case

b88b188

Udpate CHANGELOG.md

726410e

Example case cleanup

60c31f1

Additional cleanup

ff988b9

Add doc for Allam Cycle inputs

1e0f324

Correct table numbers in model_input.md

38a5713

Small fixes in docs

e5672eb

Add validation for Allam Cycle LOX retrofit settings

5c9bc51

Add existing_cap_mw default value

a9ca6bb

Remove existing_cap_mw from allamcycle csv file in example

2e301b0

Fix vRET_AllamCycleLOX into vRETCAP_AllamCycleLOX

d733913

Add note about write_capacity for allam cycle resources

abb10a8

Add docs for writing ouputs for allam cycle

9348725

Add note in write_capacityfactor for allam cycle

84a927a

complete output doc for allam cycle

5e5e1e7

Fix typo in eTotalCap_AllamcycleLOX

3a2701f

Remove multistage check in write_allamcyclelox

a594ab3

Fix startcap for allamcycle in write_capacity

bb1bf35

Add docs for writing output functions

902d464

lbonaldo force-pushed the allamcycle branch from 740cab9 to 902d464 Compare February 9, 2025 21:57

lbonaldo approved these changes Feb 9, 2025

View reviewed changes

Bump version to 0.4.4-dev.1

51f92e9

lbonaldo merged commit f72c588 into develop Feb 9, 2025

lbonaldo deleted the allamcycle branch February 9, 2025 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Allam cycle module #772

Add Allam cycle module #772

Uh oh!

qluo0320github commented Sep 19, 2024 •

edited by lbonaldo

Loading

Uh oh!

cfe316 Sep 20, 2024

Uh oh!

cfe316 Sep 20, 2024

Uh oh!

cfe316 Sep 20, 2024

Uh oh!

cfe316 Sep 20, 2024

Uh oh!

cfe316 Sep 20, 2024

Uh oh!

lbonaldo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		START_SUBPERIODS = inputs["START_SUBPERIODS"] #start
		INTERIOR_SUBPERIODS = inputs["INTERIOR_SUBPERIODS"] #interiors

Add Allam cycle module #772

Add Allam cycle module #772

Uh oh!

Conversation

qluo0320github commented Sep 19, 2024 • edited by lbonaldo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

How this can be tested

Post-approval checklist for GenX core developers

Uh oh!

cfe316 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

cfe316 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

cfe316 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

cfe316 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

cfe316 Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

lbonaldo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qluo0320github commented Sep 19, 2024 •

edited by lbonaldo

Loading