Skip to content

Conversation

@federicoparolin
Copy link
Contributor

@federicoparolin federicoparolin commented Oct 7, 2024

Description

  • Introduced additional constraints to bound the state of charge of LDS systems within the limits (zero and installed energy capacity) throughout the entire time horizon (as described in https://doi.org/10.48550/arXiv.2409.19079).
  • Saving of storage content evolution throughout the entire time horizon (StorageEvol.csv and HSC_StorageEvol.csv)

Storage content evolution over full time horizon with the original (a) and updated (b) formulations:
immagine

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Code Refactor
  • Performance Improvements

How this can be tested

Tested on "3_three_zones_w_co2_capture" enabling LDS on storage resources.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

lbonaldo and others added 2 commits September 23, 2024 17:37
@RuaridhMacd RuaridhMacd added bug Something isn't working enhancement New feature or request labels Oct 8, 2024
Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just two requests: 1. Can you please modify the relevant doc pages to reflect this change? 2. Do you have an idea of how much this increases runtime? Especially for a large case?

Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @federicoparolin, thanks so much for this PR! It looks great to me as well. I’ve added a few additional comments on the write_opwrap_lds_stor_init function, could you please take a look when you have a moment?

@lbonaldo lbonaldo self-requested a review November 18, 2024 17:13
@lbonaldo lbonaldo changed the base branch from main to develop November 18, 2024 17:19
@lbonaldo lbonaldo merged commit 6fabc96 into GenXProject:develop Nov 18, 2024
3 of 9 checks passed
@GenXProject GenXProject added this to the v0.4.2 milestone Jan 16, 2025
sambuddhac pushed a commit to sambuddhac/GenX.jl that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants