-
Notifications
You must be signed in to change notification settings - Fork 142
Clean up storage model syntax, logic #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fb4513 to
8a9f1de
Compare
Collaborator
Author
|
I've now tested this on a variant of the example |
Reduces three possible @constraint calls to one, in a single higher-level function
8a9f1de to
a055474
Compare
lbonaldo
reviewed
Jan 31, 2025
lbonaldo
reviewed
Jan 31, 2025
lbonaldo
reviewed
Jan 31, 2025
lbonaldo
approved these changes
Jan 31, 2025
Collaborator
lbonaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a couple of minor comments. Great refactoring! Thanks, @cfe316!
sambuddhac
pushed a commit
to sambuddhac/GenX.jl
that referenced
this pull request
Mar 5, 2025
* Access variables directly rather than with EP[:_] * Eliminate repeated/branching logic Reduces three possible @constraint calls to one, in a single higher-level function --------- Co-authored-by: lbonaldo <[email protected]>
sambuddhac
pushed a commit
to sambuddhac/GenX.jl
that referenced
this pull request
Mar 5, 2025
* Access variables directly rather than with EP[:_] * Eliminate repeated/branching logic Reduces three possible @constraint calls to one, in a single higher-level function --------- Co-authored-by: lbonaldo <[email protected]>
NLaws
pushed a commit
to NLaws/GenX.jl
that referenced
this pull request
Nov 8, 2025
* Access variables directly rather than with EP[:_] * Eliminate repeated/branching logic Reduces three possible @constraint calls to one, in a single higher-level function --------- Co-authored-by: lbonaldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lightly clean up the syntax and some logic in the storage model. This
What type of PR is this? (check all applicable)
Related Tickets & Documents
n/a
Checklist
How this can be tested
Strictly internal change. Should test symmetric, asymmetric, and LDS.
Post-approval checklist for GenX core developers
After the PR is approved