Modify storage_all.jl to prevent micro-charging/discharging close to capacity #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbryant
approved these changes
Feb 24, 2025
patrickbryant
left a comment
patrickbryant
left a comment
There was a problem hiding this comment.
Looks good to me! The only system I can think of where you might want to have a charge rate exceeding the available storage in a time step is a thermal battery which is being used for an industrial heat load which is being discharged. Such a system would not have the same physical constraint as an ensemble of electrochemical batteries.
patrickbryant
approved these changes
Mar 7, 2025
|
I have tested this branch and it looks good, no maximal charge-discharge when at 100% state of charge. |
…capacity This PR adds a constraint (as suggested by @patrickbryant) which attempts to prevent fast charging/discharging of storage batteries within a time step by enforcing a maximum charging rate capped at the storage capacity, less, the SOC from the last time step.
lbonaldo
force-pushed
the
sambuddhac-patch-13
branch
from
54450e4 to
d24ada1
Compare
lbonaldo
force-pushed
the
sambuddhac-patch-13
branch
from
d24ada1 to
d6a315e
Compare
lbonaldo
approved these changes
Jun 18, 2025
Collaborator
lbonaldo
left a comment
lbonaldo
left a comment
There was a problem hiding this comment.
Looks good. Thanks @sambuddhac and @patrickbryant!
NLaws
pushed a commit
to NLaws/GenX.jl
that referenced
this pull request
Nov 8, 2025
…capacity (GenXProject#836) This PR adds a constraint (as suggested by @patrickbryant) which attempts to prevent fast charging/discharging of storage batteries within a time step by enforcing a maximum charging rate capped at the storage capacity, less, the SOC from the last time step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a constraint (as suggested by @patrickbryant) which attempts to prevent fast charging/discharging of storage batteries within a time step by enforcing a maximum charging rate capped at the storage capacity, less, the SOC from the last time step.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Further addresses and refines issue #547
Checklist
How this can be tested
Post-approval checklist for GenX core developers
After the PR is approved