Fix bugs in duplication of CPTs #3625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API functions to duplicate a CPT had double allocations and freeing of strings using the wrong functions.
|
All the CI jobs are failing now. The error is: |
|
What does that mean? I ran the full test locally and only grdgdal failed. |
|
It possibly means there are some technical issues in Azure Pipelines. We have to wait for their fix. |
|
Shell I change the branch to master for this and then you backport, @seisman ? |
|
Yes, |
|
Done. |
seisman
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Blindly approve. @PaulWessel feel free to merge it if you're confident about the PR.
The CI issue was possibly fixed a few hours ago, and may be working in next few days.
|
I will run all tests on macOS and CentOS first, locally. MacOs had no failures, awaiting slower laptop... |
|
I have merged this branch @seisman |
|
So this means 6.1 is definitively dead? |
seisman
pushed a commit
that referenced
this pull request
Jul 9, 2020
* Fix bugs in duplication of CPTs The API functions to duplicate a CPT had double allocations and freeing of strings using the wrong functions. * Update gmt_support.c * Update gmt_support.c * Missing -h in docs * Add named constants
|
backport to 6.1 is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API functions to duplicate a CPT had double allocations and freeing of strings using the wrong functions. Also replace mysterious bit-values with named constants for readability. The man ages for makecpt and grd2cpt did not list the -h option (needed if you want to write CPT comments on output) and grd2cpt did not list the option (but did support it). A few minor correction to obscure test scripts that used awk to build cpts from parts. Closes #3613.