Skip to content

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Jul 8, 2020

Description of proposed changes

Adds new defaults parameter GMT_DATA_SERVER_UPDATE [1d] to control frequency of catalog refresh on local computer. Also rearranges the description of global dataset with a leading chapter on how this is done, followed by sections per dataset. I also fixed a memory leak when a module called a module and the server catalog ended up being allocated twice.

I need help with arranging this correctly so that

  1. The sidebar listing is sensible once we open Dataset
  2. The size of headers is correct [===, ---, and ~~~ do not seem to work the way I thought]

@PaulWessel PaulWessel requested a review from seisman July 8, 2020 23:24
@PaulWessel PaulWessel changed the title WIP Remote update frequency Remote update frequency Jul 9, 2020
@PaulWessel
Copy link
Member Author

Wonder if GMT_DATA_SERVER_UPDATE is the best word. We want to convey interval, frequency, etc. I can go very long with

GMT_DATA_SERVER_UPDATE_INTERVAL

but it is a bit long. remove SERVER and go with GMT_DATA_UPDATE_INTERVAL?

@seisman
Copy link
Member

seisman commented Jul 11, 2020

Wonder if GMT_DATA_SERVER_UPDATE is the best word. We want to convey interval, frequency, etc. I can go very long with

GMT_DATA_SERVER_UPDATE_INTERVAL

but it is a bit long. remove SERVER and go with GMT_DATA_UPDATE_INTERVAL?

GMT_DATA_UPDATE_INTERVAL is good to me.

PaulWessel and others added 2 commits July 10, 2020 14:31
@PaulWessel
Copy link
Member Author

looks pretty nice. If we are OK with merging this then I will wait for it to update on the web page and ask Sandwell and Müller if they would like any changes. Actually, before I do I think we should probably place their logos to give them more visual credit. I will do that later today - have another zoom then must drive all the way in to UH to pick up some books and a RAID system that needs work...

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Also backport to 6.1 branch?

@PaulWessel PaulWessel added the backport 6.1 Backport this PR to 6.1 branch label Jul 11, 2020
@PaulWessel
Copy link
Member Author

I added the IGPP and EarthByte logos, at the end of each section, but looks bad. Need to move to the header for each section, and I think we could use a horizontal line between each data set section. Will head out now, if you have ideas to make this look good please do, else I will hack later.

@seisman
Copy link
Member

seisman commented Jul 11, 2020

I've added horizontal lines between each data sets.

@PaulWessel PaulWessel merged commit c981889 into master Jul 11, 2020
@PaulWessel PaulWessel deleted the remote-update-frequency branch July 11, 2020 05:47
github-actions bot pushed a commit that referenced this pull request Jul 11, 2020
* Add new keyword for refresh frequency

* use o for month as elsewhere

* Rearrange datasets

* Update remote-data.rst

* Fix mem leaking when module called another module

* Update doc/rst/source/datasets/remote-data.rst

* Update doc/rst/source/datasets/remote-data.rst

* Update heading levels

* Update remote-data.rst

* Update name of new parameter

GMT_DATA_UPDATE_INTERVAL

* List all datasets

* add logos

* Add horizontal rules between datasets

* Add NASA logo and revise placements

Co-authored-by: Dongdong Tian <[email protected]>
PaulWessel added a commit that referenced this pull request Jul 11, 2020
* Add new keyword for refresh frequency

* use o for month as elsewhere

* Rearrange datasets

* Update remote-data.rst

* Fix mem leaking when module called another module

* Update doc/rst/source/datasets/remote-data.rst

* Update doc/rst/source/datasets/remote-data.rst

* Update heading levels

* Update remote-data.rst

* Update name of new parameter

GMT_DATA_UPDATE_INTERVAL

* List all datasets

* add logos

* Add horizontal rules between datasets

* Add NASA logo and revise placements

Co-authored-by: Dongdong Tian <[email protected]>

Co-authored-by: Paul Wessel <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 6.1 Backport this PR to 6.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants