Fix sign-error on slope for RMA regression #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, we never checked the correlation between x and y to know which sign to assign to the absolute value of teh slope. This PR fixes taht and needs backporting to 6.1.
seisman
approved these changes
Jul 9, 2020
Member
|
Blindly approve, again. |
Member
Author
I think that is OK. If data are negatively correlated we have a negative slope, but the eq for the slope is based on the ratio of two positive numbers (stdev). So using r to change the sign. |
seisman
pushed a commit
that referenced
this pull request
Jul 10, 2020
Somehow, we never checked the correlation between x and y to know which sign to assign to the absolute value of teh slope. This PR fixes taht and needs backporting to 6.1.
Member
|
Backport to 6.1 is done. |
Member
Author
|
Great thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, we never checked the correlation between x and y to know which sign to assign to the absolute value of the slope. This PR fixes that and needs back-porting to 6.1.