Fix regression on Windows when trying to find if name is a SUBDATASET. #3661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulWessel
approved these changes
Jul 14, 2020
|
Well, broken is what it was. |
|
Need to add a test since clearly no test checked this part. COuld you do that? |
|
We have many failures on Windows recently (#3642), possibly due to this bug. |
|
Does this raise to the level of a 6.1.1 before the workshop next week? |
It looks a new bug introduced after 6.1.0 release. The reasons are:
|
|
Yes, #3596 introduced the bug but lucky of us that it was hold to after 6.1, so we don't need to release a 6.1.1. Just fix it |
joa-quim
added a commit
that referenced
this pull request
Jul 14, 2020
#3661) (#3664) Closes #3657 Co-authored-by: Joaquim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3657