Place movie indicator f without any shifts #3685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we may pick up a previous setting which is not what we want here since the PS function will be run at the very end.
PaulWessel
added
bug
seisman
approved these changes
Jul 19, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2020
* THe movie indicator f uses Call_Module but must pass -X0 -Y0 Otherwise, we may pick up a previous setting which is not what we want here since the PS function will be run at the very end. * Update gmt_plot.c
seisman
pushed a commit
that referenced
this pull request
Jul 19, 2020
* THe movie indicator f uses Call_Module but must pass -X0 -Y0 Otherwise, we may pick up a previous setting which is not what we want here since the PS function will be run at the very end. * Update gmt_plot.c Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The movie progress indicator f is unlike the other 5 (a-e) in that it needs to call GMT_Call_Module to draw an annotated axis via basemap. However, I noticed that if the movie frame started off with -Xc and/or -Yc then GMT_Call_Module would pick up those settings from gmt.history. Because the module is just building a PostScript function that will be executed by gmt end we do not want to double up on those offsets. Hence, we now pass -X0 -Y0 to ensure nothing is shifted. We also added --GMT_HISTORY=false to prevent any writing, just like we do elsewhere. A separate PR will replace false with readonly. This necessitated a longer cmd[GMT_LEN256] string as well.