Let grdcontour -N support the oneliner syntax #3702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THe problem is that grdcontour -N calls grdview and then itself via GMT_Call_Module. However, we have already flagged it as a oneliner but now there are several calls. The solution was to not trigger the oneliner check for grdcontour -N and then detect it instead in the special -N branch in grdcontour. We parse the options and discover if the command was a oneliner or not, and if it is we craft the gmt begin call needed and add the gnt end show call at the end. Seems to work.
joa-quim
approved these changes
Jul 22, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2020
THe problem is that grdcontour -N calls grdview and then itself via GMT_Call_Module. However, we have already flagged it as a oneliner but now there are several calls. The solution was to not trigger the oneliner check for grdcontour -N and then detect it instead in the special -N branch in grdcontour. We parse the options and discover if the command was a oneliner or not, and if it is we craft the gmt begin call needed and add the gnt end show call at the end. Seems to work.
joa-quim
pushed a commit
that referenced
this pull request
Jul 22, 2020
THe problem is that grdcontour -N calls grdview and then itself via GMT_Call_Module. However, we have already flagged it as a oneliner but now there are several calls. The solution was to not trigger the oneliner check for grdcontour -N and then detect it instead in the special -N branch in grdcontour. We parse the options and discover if the command was a oneliner or not, and if it is we craft the gmt begin call needed and add the gnt end show call at the end. Seems to work. Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THe problem is that grdcontour -N calls grdview and then itself via GMT_Call_Module. However, we have already flagged it as a oneliner but now there are several calls. The solution was to not trigger the oneliner check for grdcontour -N and then detect it instead in the special -N branch in grdcontour. We parse the options and discover if the command was a oneliner or not, and if it is we craft the gmt begin call needed and add the gmt end show call at the end. Seems to work.
Addresses aspects of #3701 but not the external part.