Failed to requiest more memory in stair-step function #3709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function gmtvector_fix_up_path_cartonly builds a stair-step curve from an array by adding the extra horizontal or vertical steps, thus lengthening the array. Yet, there was no check to allocate more memory once we passed the initial GMT_INITIAL_MEM_ROW_ALLOC points. So it took a large file to exceed that and then crash, reveling the bug.
seisman
approved these changes
Jul 22, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2020
The function gmtvector_fix_up_path_cartonly builds a stair-step curve from an array by adding the extra horizontal or vertical steps, thus lengthening the array. Yet, there was no check to allocate more memory once we passed the initial GMT_INITIAL_MEM_ROW_ALLOC points. So it took a large file to exceed that and then crash, reveling the bug.
PaulWessel
added a commit
that referenced
this pull request
Jul 23, 2020
The function gmtvector_fix_up_path_cartonly builds a stair-step curve from an array by adding the extra horizontal or vertical steps, thus lengthening the array. Yet, there was no check to allocate more memory once we passed the initial GMT_INITIAL_MEM_ROW_ALLOC points. So it took a large file to exceed that and then crash, reveling the bug. Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function gmtvector_fix_up_path_cartonly builds a stair-step curve from an array by adding the extra horizontal or vertical steps, thus lengthening the array. Yet, there was no check to allocate more memory once we passed the initial GMT_INITIAL_MEM_ROW_ALLOC points. So it took a large file to exceed that and then crash, reveling the bug.