grdseamount must write grids even if no change for a time-step #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of warning of no input for a time, it actually skipped writing an empty (incremental) or unchanged (cumulative) grid, which breaks workflows that makes movies or computes flexure. Now we just warn, and clarify in man page.
PaulWessel
added
bug
seisman
approved these changes
Jul 23, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2020
* grdseamount must write grids even if no change for a time-step Instead of warning of no input for a time, it actually skipped writing an empty (incremental) or unchanged (cumulative) grid, which breaks workflows that makes movies or computes flexure. Now we just warn, and clarify in man page. * Update grdseamount.rst
seisman
pushed a commit
that referenced
this pull request
Jul 23, 2020
#3716) * grdseamount must write grids even if no change for a time-step Instead of warning of no input for a time, it actually skipped writing an empty (incremental) or unchanged (cumulative) grid, which breaks workflows that makes movies or computes flexure. Now we just warn, and clarify in man page. * Update grdseamount.rst Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -T range may include times when there is no seamounts being grown or there is no change. Instead of warning of no input for a time, it actually skipped writing an empty (incremental) or unchanged (cumulative) grid, which breaks workflows that makes movies or computes flexure. Now we just warn, and clarify in man page.