pssac: Use Cartesian projection by default unless -S is used #4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For most GMT modules, if -J is not given, GMT uses -JX15c for Cartesian data, and -JQ15c for Geographic data. pssac can either plot seismograms as time series (Cartesian data) or plot seismograms on maps (Geographic data). Currently, pssac always uses -JQ15c when -J is not given. Plotting seismograms as time series gives the following error: ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single sac [ERROR]: -S option is needed in geographic plots. ``` because GMT sets the default -JQ15c. But for geographic plots, -S (controling the waveform time scaling) is required. Obviously, the -JQ15c is the wrong choice. This PR fixes the issue. In this PR, pssac always use Cartesian projection, unless -S is used. All tests still pass. With this PR, the command ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single ``` plots seismograms using -JX15c, and command (with -S option) ``` gmt sac *.z -R-120/-40/35/65 -Baf -M1i -S300c -pdf map ``` plots seismograms on maps, using -JQ15c.
|
This PR works as expected, but I'm not sure if these changes are the best way to do this. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2020
For most GMT modules, if -J is not given, GMT uses -JX15c for Cartesian data, and -JQ15c for Geographic data. pssac can either plot seismograms as time series (Cartesian data) or plot seismograms on maps (Geographic data). Currently, pssac always uses -JQ15c when -J is not given. Plotting seismograms as time series gives the following error: ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single sac [ERROR]: -S option is needed in geographic plots. ``` because GMT sets the default -JQ15c. But for geographic plots, -S (controling the waveform time scaling) is required. Obviously, the -JQ15c is the wrong choice. This PR fixes the issue. In this PR, pssac always use Cartesian projection, unless -S is used. All tests still pass. With this PR, the command ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single ``` plots seismograms using -JX15c, and command (with -S option) ``` gmt sac *.z -R-120/-40/35/65 -Baf -M1i -S300c -pdf map ``` plots seismograms on maps, using -JQ15c.
seisman
added a commit
that referenced
this pull request
Aug 28, 2020
…4094) For most GMT modules, if -J is not given, GMT uses -JX15c for Cartesian data, and -JQ15c for Geographic data. pssac can either plot seismograms as time series (Cartesian data) or plot seismograms on maps (Geographic data). Currently, pssac always uses -JQ15c when -J is not given. Plotting seismograms as time series gives the following error: ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single sac [ERROR]: -S option is needed in geographic plots. ``` because GMT sets the default -JQ15c. But for geographic plots, -S (controling the waveform time scaling) is required. Obviously, the -JQ15c is the wrong choice. This PR fixes the issue. In this PR, pssac always use Cartesian projection, unless -S is used. All tests still pass. With this PR, the command ``` gmt sac seis.SAC -R9/20/-2/2 -Baf -Fr -Gp+gblack -Gn+gred -pdf single ``` plots seismograms using -JX15c, and command (with -S option) ``` gmt sac *.z -R-120/-40/35/65 -Baf -M1i -S300c -pdf map ``` plots seismograms on maps, using -JQ15c. Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
For most GMT modules, if -J is not given, GMT uses -JX15c for Cartesian
data, and -JQ15c for Geographic data.
pssac can either plot seismograms as time series (Cartesian data)
or plot seismograms on maps (Geographic data). Currently, pssac always
uses -JQ15c when -J is not given.
Plotting seismograms as time series gives the following error:
because GMT sets the default -JQ15c. But for geographic plots, -S
(controling the waveform time scaling) is required.
Obviously, the -JQ15c is the wrong choice. This PR fixes the issue.
In this PR, pssac always use Cartesian projection, unless -S is used.
All tests still pass. With this PR, the command
plots seismograms using -JX15c, and command (with -S option)
plots seismograms on maps, using -JQ15c.