Disallow ---version and --show-datadir on module calls #4097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --version and --show-datadir could be given to modules, but the price we paid was a memory leak and a call to exit. Since the gmt driver can return those parameters, as can the API, we remove these offensive lines.
PaulWessel
added
bug
joa-quim
approved these changes
Aug 28, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2020
The --version and --show-datadir could be given to modules, but the price we paid was a memory leak and a call to exit. Since the gmt driver can return those parameters, as can the API, we remove these offensive lines.
joa-quim
pushed a commit
that referenced
this pull request
Aug 28, 2020
The --version and --show-datadir could be given to modules, but the price we paid was a memory leak and a call to exit. Since the gmt driver can return those parameters, as can the API, we remove these offensive lines. Co-authored-by: Paul Wessel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --version and --show-datadir options could be given to modules (e.g.,
gmt psxy --version), but the price we paid was a memory leak and a call to exit. Since the gmt driver can return those parameters, as can the API, we remove these offensive lines.