Properly set min/max, lat-lilmit for global small circle #5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this does not fix #4551 it fixes a minor bug that appears not to have caused any problems (yet). At least now, when checking if the four map corners are inside or outside the large solar polygon it returns the correct results. We are just not handling the case correct yet.
Member
Author
|
Need this tiny one approved so I can merge in and test a real pssolar fix... |
seisman
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this does not fix #4551 it fixes a minor bug that appears not to have caused any problems (yet). At least now, when checking if the four map corners are inside or outside the large solar polygon it returns the correct results. We are just not handling the plotting correctly yet.