This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Fix deep links now working as expected on cold start of the app. #2453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change works around an issue causing deep links to not work during app sessions that were started via deep link (more details here). I found that
isCollapsedreturnsfalsefor the entire duration of these sessions despiteviewControllersonly containing a single view controller, which could be considered as "collapsed". Perhaps on devices where only one view controller could ever be presented UIKit doesn't update the value ifisCollapsed.I tested this out on iPad, where
isCollapsedis alwaysfalse, and on an iPhone XS Max whereisCollapsedcan actually mutate between landscape and portrait, and everything seemed to work smoothly. I'd suggest this as a fix for the issue! If you'd like me to dig deeper on the subject I can try to find out more about the nature of this issue.