Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Conversation

@timonus
Copy link
Contributor

@timonus timonus commented Nov 18, 2018

This change works around an issue causing deep links to not work during app sessions that were started via deep link (more details here). I found that isCollapsed returns false for the entire duration of these sessions despite viewControllers only containing a single view controller, which could be considered as "collapsed". Perhaps on devices where only one view controller could ever be presented UIKit doesn't update the value if isCollapsed.

I tested this out on iPad, where isCollapsed is always false, and on an iPhone XS Max where isCollapsed can actually mutate between landscape and portrait, and everything seemed to work smoothly. I'd suggest this as a fix for the issue! If you'd like me to dig deeper on the subject I can try to find out more about the nature of this issue.

@rnystrom
Copy link
Member

Thank you!!

@rnystrom rnystrom merged commit 907ee5e into GitHawkApp:master Nov 19, 2018
@ijm8710 ijm8710 mentioned this pull request Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants