Switch cache format from JSON back to YAML #3810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache format for version variables has been changed from JSON to YAML in `GitVersionCache` and `VersionVariableSerializer` classes, to provide more readable and easily editable files. Code changes also include updates in the test files reflecting the change in the format. In addition, added arm64 architecture support back.
|
Thank you @arturcic for your contribution! |
arturcic
added a commit
to arturcic/GitVersion
that referenced
this pull request
Nov 30, 2023
Switch cache format from JSON back to YAML
arturcic
added a commit
that referenced
this pull request
Nov 30, 2023
Switch cache format from JSON back to YAML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache format for version variables has been changed from JSON to YAML in
GitVersionCacheandVersionVariableSerializerclasses.This is intended to fix the arm64 support that was broken. For some reason the serialization as json for the cache isn't working. We need more investigation, so reverting back to yaml, but taking in consideration the recent changes. The YamlDotnet will be a dependency on GitVersion.Output and not GitVersion.Core