-
Notifications
You must be signed in to change notification settings - Fork 664
Topological commit sort causes issues when master is merged into a feature branch #4356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HHobeck
merged 2 commits into
GitTools:main
from
HHobeck:feature/4347-topological-commit-sort
Jan 8, 2025
Merged
Topological commit sort causes issues when master is merged into a feature branch #4356
HHobeck
merged 2 commits into
GitTools:main
from
HHobeck:feature/4347-topological-commit-sort
Jan 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5c71df to
e65eded
Compare
asbjornu
requested changes
Jan 7, 2025
src/GitVersion.Core/VersionCalculation/IncrementStrategyFinder.cs
Outdated
Show resolved
Hide resolved
src/GitVersion.Core/VersionCalculation/VersionSearchStrategies/TaggedCommitVersionStrategy.cs
Outdated
Show resolved
Hide resolved
src/GitVersion.Core/VersionCalculation/VersionSearchStrategies/TaggedCommitVersionStrategy.cs
Outdated
Show resolved
Hide resolved
src/GitVersion.Core/VersionCalculation/VersionSearchStrategies/TaggedCommitVersionStrategy.cs
Outdated
Show resolved
Hide resolved
864b630 to
9794598
Compare
asbjornu
approved these changes
Jan 7, 2025
Contributor
|
Thank you @HHobeck for your contribution! |
This was referenced Jul 25, 2025
This was referenced Aug 1, 2025
This was referenced Aug 15, 2025
This was referenced Aug 25, 2025
This was referenced Sep 1, 2025
This was referenced Oct 1, 2025
This was referenced Oct 30, 2025
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #4347
Checklist: