Skip to content

Conversation

@viktorrenkema
Copy link
Contributor

@viktorrenkema viktorrenkema commented Oct 31, 2025

This PR handles the GBO-side of enabling cover height resizing. The basic idea is:

  1. by default, we handle cover images the same as usual (aka there's a fixed aspect ratio as recommended in the docs that we adhere to, so this can lead to cover images of e.g. < 100px tall on smaller viewports)
  2. if height exists on the page cover, it means the cover was resized. because we can't/shouldnt enforce an aspect ratio on a cover that has a dynamic height, different logic kicks in to determine the appropriate height depending on the dimensions so that the entire image is contained within the cover

The previous PR was reverted, as we didn't do step 1 above: we applied the 'new' sizing rules to existing page covers, which causes a lot of existing page covers to regress.

To help explain how a page cover has a fixed aspect ratio by default but how setting a height will impact that, we have tooltip UI in the editor + I have a CR ready to add more details in the support article.

CleanShot.2025-11-03.at.15.21.03.mp4

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: 3e31638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@argos-ci
Copy link

argos-ci bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 1 changed, 4 added Nov 5, 2025, 1:09 PM
v2-cloudflare (Inspect) 👍 Changes approved 1 changed Nov 5, 2025, 1:12 PM
v2-vercel (Inspect) 👍 Changes approved 2 changed Nov 5, 2025, 1:12 PM

@viktorrenkema viktorrenkema force-pushed the viktor/support-custom-cover-heights branch from a207335 to 45e5c86 Compare October 31, 2025 19:28
@viktorrenkema viktorrenkema force-pushed the viktor/support-custom-cover-heights branch from 45e5c86 to 9cfddb9 Compare October 31, 2025 19:35
@viktorrenkema viktorrenkema force-pushed the viktor/support-custom-cover-heights branch from 9cfddb9 to 9cd0359 Compare October 31, 2025 19:46
@viktorrenkema viktorrenkema marked this pull request as ready for review November 3, 2025 14:23
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it an issue that both light and dark image use the same sizes/aspect-ratio/position ?

@viktorrenkema
Copy link
Contributor Author

Isn't it an issue that both light and dark image use the same sizes/aspect-ratio/position ?

Yeah it is, I listed the same as a current limitation somewhere in another PR. I chatted about it with samy but while it'd be nice to support heights and object fit on both dark and light mode individually, its just not included yet in this feature release.

@viktorrenkema viktorrenkema force-pushed the viktor/support-custom-cover-heights branch from 4ed4d44 to 3e31638 Compare November 5, 2025 13:02
@viktorrenkema viktorrenkema merged commit 35dcaca into main Nov 5, 2025
19 of 20 checks passed
@viktorrenkema viktorrenkema deleted the viktor/support-custom-cover-heights branch November 5, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants