New initialisation code #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
new_init
branch
from
9a8603d to
5bb9eb6
Compare
Member
Author
|
Nearly working but while it now seems the interface object is passed back to Godot properly, Godot can't call into any of our methods |
Member
Author
|
Ok, fix by Fales solves the aforementioned issue. Once that is all merged and I can confirm this works, I'm merging this. |
BastiaanOlij
force-pushed
the
new_init
branch
from
5bb9eb6 to
4860c8f
Compare
BastiaanOlij
force-pushed
the
new_init
branch
from
4860c8f to
980acc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing over to new initialization code.
Requires: godotengine/godot#52562
And: vnen/godot-cpp#19