Skip to content

Conversation

@cfloress
Copy link
Contributor

@cfloress cfloress commented Nov 15, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team as code owners November 15, 2025 21:02
@snippet-bot
Copy link

snippet-bot bot commented Nov 15, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 15, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a suite of new samples demonstrating the 'live generation' features of the GenAI SDK, enabling real-time interactions with Gemini models for tasks such as audio synthesis, code execution, and audio transcription. Simultaneously, it refactors existing code to enhance consistency by standardizing the use of a predefined constant for the user role, contributing to a more robust and maintainable codebase.

Highlights

  • New Live Generation Samples: Four new Go samples have been added under the genai/live/ directory, showcasing various real-time interaction capabilities with Gemini models. These include generating audio responses from text, executing code based on text input, transcribing audio input and output, and performing basic live text generation.
  • Role Constant Refactoring: Existing genai samples have been updated to improve code consistency and maintainability. The string literal "user" used for the Role field in genai.Content has been replaced with the genai.RoleUser constant across numerous files.
  • Expanded Test Coverage: The genai/live/live_examples_test.go file has been updated to include new mock functions and corresponding test cases, ensuring the functionality and proper integration of the newly introduced live generation samples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new samples for live generation with the GenAI SDK and refactors the use of role strings to constants, which is a great improvement for code quality.

I've reviewed the changes and have the following feedback:

  • The new samples are well-written, but I found a few areas for improvement, including some leftover development code (commented-out code, debug prints), a hardcoded output file path, and one case of incomplete response handling that could lead to missing the model's final answer.
  • The refactoring from "user" to genai.RoleUser is applied consistently. However, I noticed one instance where this constant is used for a system instruction, which is likely incorrect.
  • The refactoring seems incomplete as other role strings like "system" and "model" are still used as magic strings in the codebase. It would be great to replace them with constants as well for consistency.

I've left specific comments with suggestions on the relevant lines of code. Overall, this is a valuable addition to the samples.

Copy link

@Guiners Guiners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants